Apply current cursor expansion scale to trail parts #29515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, lazer does not apply the current cursor expansion scale to trail parts which doesn't match stable behaviour.
This PR changes it so when a trail part is created, the current cursor expansion scale is applied.
Just a note that I'm not very familiar with the code base, so apologies if there is a more efficient way of implementing this behaviour.
Also note that this does change the behaviour of both the argon and triangles skin, both of which never had cursor trail expanding. I'm unsure if you'd like this to be addressed or not, but I've kept it in as 1) I expect it to work this way and 2) it's how the default skin behaves in stable.