Redesign timing table tracking

[bdach]

• Depends on Remove dead row attribute classes #29531
• Closes Beatmap Editor ControlPointTable lock and "use current time" issue with EffectControlPoint #23197

RFC. This change reverts some behaviours of the timing screen that were (in my view) causing overall jankness, and manifested in actual issues such as #23147. The general spirit of the change is "don't try to do too much for the user".

The reason why I went in this direction is that rather than layer additional silent mechanics onto this screen such as "locking rows" or whatever, I'd like to try removing automation first and seeing how that gets received. Something something, "perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away".

• On entering the screen, the timing point active at the current instant of the map is selected. This is the only time where the selected point is changed automatically for the user.

• The ongoing automatic tracking of the relevant point after the initial selection is gone. Even knowing the fact that it was supposed to track the supposedly relevant "last selected type" of control point, I always found the tracking to be fairly arbitrary in how it works. Removing this behaviour also incidentally fixes Can't move timing point using "Use current time" #23147.

  In its stead, to indicate which timing groups are having an effect, they receive an indicator line on the left (coloured using the relevant control points' representing colours), as well as a slight highlight effect.

• If there is no control point selected, the table will autoscroll to the latest timing group, unless the user manually scrolled the table before.

• If the selected control point changes, the table will autoscroll to the newly selected point, regardless of whether the user manually scrolled the table before.

• A new button is added which permits the user to select the latest timing group. As per the point above, this will autoscroll the user to that group at the same time.

Additional test coverage for these behaviours can be added once I'm sure this PR won't get immediately dumpstered on sight.

[peppy]

I'm okay with these changes, but I do think the buttons for creating new points (both of them) should be a different colour to the new one which jumps around.

[bdach]

Does c4f08b4 work for you?

[peppy]

Hmm, might be a bit too colourful now 😅 I'll have a look now.

[peppy]

How about this?

diff --git a/osu.Game/Screens/Edit/Timing/ControlPointList.cs b/osu.Game/Screens/Edit/Timing/ControlPointList.cs
index cbef0b9064..8699c388b3 100644
--- a/osu.Game/Screens/Edit/Timing/ControlPointList.cs
+++ b/osu.Game/Screens/Edit/Timing/ControlPointList.cs
@@ -44,6 +44,26 @@ private void load(OsuColour colours)
                     Groups = { BindTarget = Beatmap.ControlPointInfo.Groups, },
                 },
                 new FillFlowContainer
+                {
+                    AutoSizeAxes = Axes.Both,
+                    Anchor = Anchor.BottomLeft,
+                    Origin = Anchor.BottomLeft,
+                    Direction = FillDirection.Horizontal,
+                    Margin = new MarginPadding(margins),
+                    Spacing = new Vector2(5),
+                    Children = new Drawable[]
+                    {
+                        new RoundedButton
+                        {
+                            Text = "Select closest to current time",
+                            Action = goToCurrentGroup,
+                            Size = new Vector2(220, 30),
+                            Anchor = Anchor.BottomRight,
+                            Origin = Anchor.BottomRight,
+                        },
+                    }
+                },
+                new FillFlowContainer
                 {
                     AutoSizeAxes = Axes.Both,
                     Anchor = Anchor.BottomRight,
@@ -68,15 +88,6 @@ private void load(OsuColour colours)
                             Size = new Vector2(160, 30),
                             Anchor = Anchor.BottomRight,
                             Origin = Anchor.BottomRight,
-                            BackgroundColour = colours.Green3,
-                        },
-                        new RoundedButton
-                        {
-                            Text = "Go to current time",
-                            Action = goToCurrentGroup,
-                            Size = new Vector2(140, 30),
-                            Anchor = Anchor.BottomRight,
-                            Origin = Anchor.BottomRight,
                         },
                     }
                 },

In a future effort we should re-think these buttons. For instance, delete may work better inline in the table to allow for quick deletion, or even in the right control area.

[peppy]

As commented.

[bdach]

Sure, fine to apply.

[peppy]

On a code and UX pass this seems okay. I still kinda liked the previous behaviour but let's see if I was alone or others ask for this to return.

@bdach I'm okay with or without tests, so up to you.

[bdach]

I'm just gonna merge /shrug