Fix legacy key counter position not matching stable #29536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stable, the key counter display is positioned to the centre right of the screen pushed 40 pixels upwards in a 640x480 coordinates system (i.e. stable's coordinates system):
https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/Input/Drawable/InputOverlay.cs#L40-L41
To achieve the same behaviour, we use
CentreRightanchor,TopRightorigin, and push the key counter upwards by 64 pixels (that is, 40 pixels but multiplied by the 1.6 constant).Precedents of using the 1.6 constant can be seen in
LegacyHealthDisplay. The reason why the constant is applied there is because stable works in a 640x480 system, meanwhile lazer works in a 1024x768 system, therefore we have to multiply by 1.6 to translate the delta across.