Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save custom sound banks to beatmap #29566

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Save custom sound banks to beatmap #29566

wants to merge 15 commits into from

Commits on Aug 21, 2024

  1. Add custom sound banks to legacy encoder

    @kstefanowicz
    kstefanowicz committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    618792b View commit details
    Browse the repository at this point in the history

  2. Check for custom sound banks first

    @kstefanowicz
    kstefanowicz committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8b31ef2 View commit details
    Browse the repository at this point in the history

  3. Add custom sound banks to legacy decoder

    @kstefanowicz
    kstefanowicz committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    95daa4c View commit details
    Browse the repository at this point in the history

  4. Remove "none" from AvailableSoundBanks

    @kstefanowicz
    kstefanowicz committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4e729ce View commit details
    Browse the repository at this point in the history

  5. Adjust formatting

    @kstefanowicz
    kstefanowicz committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    02a8676 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Move AvailableSampleBanks to ConvertHitObjectParser

    @kstefanowicz
    kstefanowicz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    abea1a5 View commit details
    Browse the repository at this point in the history

  2. Add fallback for invalid bank default to normal

    @kstefanowicz
    kstefanowicz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    eb58837 View commit details
    Browse the repository at this point in the history

  3. Fix AvailableSampleBanks.Count to reflect 0-index

    @kstefanowicz
    kstefanowicz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ecdc3cb View commit details
    Browse the repository at this point in the history

  4. Prevent regular sound banks from being added to CustomSoundBanks in .… 

    …osu file
    @kstefanowicz
    kstefanowicz committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a1f5679 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Move custom sound bank check before writing colors in encoder

    @kstefanowicz
    kstefanowicz committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    785ef22 View commit details
    Browse the repository at this point in the history

  2. Add check for IHasRepeats to get banks from sliders

    @kstefanowicz
    kstefanowicz committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a790127 View commit details
    Browse the repository at this point in the history

  3. Remove MacOS Using

    @kstefanowicz
    kstefanowicz committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    9ae49f8 View commit details
    Browse the repository at this point in the history

  4. Address null reference warnings

    @kstefanowicz
    kstefanowicz committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2c65fe1 View commit details
    Browse the repository at this point in the history

  5. Add check for empty NodeSamples

    @kstefanowicz
    kstefanowicz committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    e898433 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Address code quality issues

    @kstefanowicz
    kstefanowicz committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    7bb955b View commit details
    Browse the repository at this point in the history