Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve song select load and reload with large beatmap databases #29639

Merged
merged 21 commits into from
Aug 30, 2024

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    466ed5d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4d42274 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    081c9eb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    81b36d8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b1f6538 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c2c1dcc View commit details
    Browse the repository at this point in the history
  7. Remove song select preloading

    Really unnecessary now.
    peppy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5ed0c6e View commit details
    Browse the repository at this point in the history
  8. Allow running initial filter criteria asynchronously

    This reverts a portion of ppy#9539.
    
    The rearrangement in `SongSelect` is required to get the initial filter
    into `BeatmapCarousel` (and avoid the `FilterChanged` event firing,
    causing a delayed/scheduled filter application).
    peppy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    336abad View commit details
    Browse the repository at this point in the history
  9. Always debounce external Filter requests (except for tests)

    The only exception to the rule here was "when screen isn't active apply
    without debounce" but I'm not sure we want this. It would cause a
    stutter on returning to song select and I'm not even sure this is a
    common scenario.
    
    I'd rather remove it and see if someone finds an actual case where this
    is an issue.
    peppy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    dd4a110 View commit details
    Browse the repository at this point in the history
  10. Fix multiple test failures

    peppy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9123d2c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    853023d View commit details
    Browse the repository at this point in the history
  12. Tidy up test beatmap loading

    peppy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e04b5bb View commit details
    Browse the repository at this point in the history
  13. Remove loadedTestBeatmaps flag

    peppy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1776d38 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Fix some tests not always waiting long enough for beatmap loading

    These used to work because there was a huge blocking load operation,
    which is now more asynchronous.
    
    Note that the change made in `SongSelect` is not required, but defensive
    (feels it should have been doing this the whole time).
    peppy committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    def1aba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1d2591 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c013974 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Remove TODO

    peppy committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    291dd5b View commit details
    Browse the repository at this point in the history
  2. Mark BeatmapSets as internal

    peppy committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    1b9942c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2033a5e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    de208fd View commit details
    Browse the repository at this point in the history
  5. Fix beatmap not being detached on hide/unhide

    The explicit detach call was removed from `updateBeatmapSet`, causing
    this to occur. We could optionally add it back (it will be a noop in all
    cases though).
    peppy committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    7b6e622 View commit details
    Browse the repository at this point in the history