-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve song select load and reload with large beatmap databases #29639
Merged
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 466ed5d - Browse repository at this point
Copy the full SHA 466ed5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d42274 - Browse repository at this point
Copy the full SHA 4d42274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 081c9eb - Browse repository at this point
Copy the full SHA 081c9ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81b36d8 - Browse repository at this point
Copy the full SHA 81b36d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1f6538 - Browse repository at this point
Copy the full SHA b1f6538View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2c1dcc - Browse repository at this point
Copy the full SHA c2c1dccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ed0c6e - Browse repository at this point
Copy the full SHA 5ed0c6eView commit details -
Allow running initial filter criteria asynchronously
This reverts a portion of ppy#9539. The rearrangement in `SongSelect` is required to get the initial filter into `BeatmapCarousel` (and avoid the `FilterChanged` event firing, causing a delayed/scheduled filter application).
Configuration menu - View commit details
-
Copy full SHA for 336abad - Browse repository at this point
Copy the full SHA 336abadView commit details -
Always debounce external
Filter
requests (except for tests)The only exception to the rule here was "when screen isn't active apply without debounce" but I'm not sure we want this. It would cause a stutter on returning to song select and I'm not even sure this is a common scenario. I'd rather remove it and see if someone finds an actual case where this is an issue.
Configuration menu - View commit details
-
Copy full SHA for dd4a110 - Browse repository at this point
Copy the full SHA dd4a110View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9123d2c - Browse repository at this point
Copy the full SHA 9123d2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 853023d - Browse repository at this point
Copy the full SHA 853023dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e04b5bb - Browse repository at this point
Copy the full SHA e04b5bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1776d38 - Browse repository at this point
Copy the full SHA 1776d38View commit details
Commits on Aug 29, 2024
-
Fix some tests not always waiting long enough for beatmap loading
These used to work because there was a huge blocking load operation, which is now more asynchronous. Note that the change made in `SongSelect` is not required, but defensive (feels it should have been doing this the whole time).
Configuration menu - View commit details
-
Copy full SHA for def1aba - Browse repository at this point
Copy the full SHA def1abaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1d2591 - Browse repository at this point
Copy the full SHA d1d2591View commit details -
Configuration menu - View commit details
-
Copy full SHA for c013974 - Browse repository at this point
Copy the full SHA c013974View commit details
Commits on Aug 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 291dd5b - Browse repository at this point
Copy the full SHA 291dd5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b9942c - Browse repository at this point
Copy the full SHA 1b9942cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2033a5e - Browse repository at this point
Copy the full SHA 2033a5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for de208fd - Browse repository at this point
Copy the full SHA de208fdView commit details -
Fix beatmap not being detached on hide/unhide
The explicit detach call was removed from `updateBeatmapSet`, causing this to occur. We could optionally add it back (it will be a noop in all cases though).
Configuration menu - View commit details
-
Copy full SHA for 7b6e622 - Browse repository at this point
Copy the full SHA 7b6e622View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.