Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mouse input from mania touch controls #29654

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

smoogipoo
Copy link
Contributor

Resolves #29378

I agree this is unnecessary.

@peppy
Copy link
Sponsor Member

peppy commented Aug 30, 2024

I'm fine with giving this a try. The edge case would be a user with touch input that's being mapped to a mouse in windows (used to be a more common thing, but probably much less so these days as vendors want to make use of proper touch input that windows offers).

@peppy peppy enabled auto-merge August 30, 2024 07:40
@bdach
Copy link
Collaborator

bdach commented Aug 30, 2024

I don't normally advocate for toggles but we already have a toggle that this could be pulled under?

new SettingsCheckbox
{
LabelText = MouseSettingsStrings.DisableClicksDuringGameplay,
Current = osuConfig.GetBindable<bool>(OsuSetting.MouseDisableButtons)
},

@smoogipoo
Copy link
Contributor Author

Actually, that setting already works to disable this overlay. I'd be alright with that direction, depending on what @peppy says.

@peppy
Copy link
Sponsor Member

peppy commented Aug 30, 2024

Honestly I say we just nuke it for now and see if a single person complains. Returning under that setting is a fine compromise if there's valid reason to leave it.

@bdach bdach disabled auto-merge August 30, 2024 12:11
@bdach bdach merged commit 672fe1b into ppy:master Aug 30, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osu!mania touch input shows up with "touch" setting disabled
3 participants