Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FastCircle in demanding places in the editor #29660

Merged
merged 4 commits into from
Sep 1, 2024
Merged

Use FastCircle in demanding places in the editor #29660

merged 4 commits into from
Sep 1, 2024

Conversation

EVAST9919
Copy link
Contributor

@EVAST9919 EVAST9919 commented Aug 30, 2024 •
edited by peppy
Loading

  • Depends on framework update

Performance difference can be seen in ppy/osu-framework#6290 OP.
Few extra screenshots showing draw calls difference and batching:

draw-calls-master draw-calls-pr batching 1 batching 2 batching 3
mania-master-calls mania-pr-calls Снимок экрана 2024-08-30 173537 Снимок экрана 2024-08-30 173605 Снимок экрана 2024-08-30 173824

Other potential use cases (not included in this pr):

hit error meters timing distribution graph
osu_2024-08-30_18-20-46 osu_2024-08-30_18-21-01

@peppy peppy self-requested a review September 1, 2024 10:09
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 1, 2024
@peppy peppy enabled auto-merge September 1, 2024 10:36
@peppy peppy merged commit 6c5ce36 into ppy:master Sep 1, 2024
9 checks passed
@EVAST9919 EVAST9919 deleted the fast-circle branch September 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:editor size/S type:performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EVAST9919 @peppy @Joehuu