Fix per-frame allocations in BeatmapCarousel
#29688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
peppy
commented
Sep 4, 2024
peppy
commented
| Before | After |
|---|---|
 |
 |
smoogipoo
reviewed
Sep 4, 2024
| public IEnumerable<DrawableCarouselItem> DrawableBeatmaps => beatmapContainer?.IsLoaded != true ? Enumerable.Empty<DrawableCarouselItem>() : beatmapContainer.AliveChildren; | ||
|
|
||
| private Container<DrawableCarouselItem>? beatmapContainer; | ||
| public Container<DrawableCarouselItem>? Beatmaps; |
There was a problem hiding this comment.
I think I'd prefer this to be private and exposed as an IReadOnlyList.
There was a problem hiding this comment.
Just to confirm, this means using the for loop as you proposed?
peppy
force-pushed
the
fix-song-select-allocs
branch
from
63b0368
to
dfe11dc
Compare
peppy
added
the
next release
bdach
approved these changes
Sep 4, 2024
| @@ -51,7 +51,7 @@ public partial class DrawableCarouselBeatmapSet : DrawableCarouselItem, IHasCont | |||
| [Resolved] | |||
| private IBindable<RulesetInfo> ruleset { get; set; } = null!; | |||
|
|
|||
| public IEnumerable<DrawableCarouselItem> DrawableBeatmaps => beatmapContainer?.IsLoaded != true ? Enumerable.Empty<DrawableCarouselItem>() : beatmapContainer.AliveChildren; | |||
| public IReadOnlyList<DrawableCarouselItem> DrawableBeatmaps => beatmapContainer?.IsLoaded != true ? Array.Empty<DrawableCarouselItem>() : beatmapContainer; | |||
There was a problem hiding this comment.
Can't immediately tell if the AliveChildren to Children swap here is correct but I don't think we do any lifetime games in song select so I think it should be
There was a problem hiding this comment.
Yeah it seemed fine. Worst case it's just setting some values when not required, but it's worth the alloc saving.
smoogipoo
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.