Continue displaying storyboard even if fully dimmed in specific circumstances #29967
Conversation
| /// </item> | ||
| /// </list> | ||
| /// </summary> | ||
| private readonly Lazy<bool> storyboardMustAlwaysBePresent; |
There was a problem hiding this comment.
The Lazy usage here is primarily intended to prevent the recalculation of the heuristic conditions described, which can get pretty heavy on maps like https://osu.ppy.sh/beatmapsets/470977#osu/1010030 (measured at least 3ms spent on computing this in profiling per call). That said, it doesn't do that much, so it could be skipped if deemed offensive.
There was a problem hiding this comment.
Any reason for it to not be computed once in LoadComplete() instead?
There was a problem hiding this comment.
Um... I guess you could, but it gets rather finicky, because if you do that you need to start worrying about call order - ShowDimContent is checked in UpdateVisuals() in UserDimContainer which is called in several places there, and one of them is... UserDimContainer.LoadComplete(). So one would have to be careful to compute this before that base call.
RFC.
Closes #9315.
Closes #29867.
Notably, this does nothing about #25075, but I'm not sure what to do with that one in the first place.