Fix sliderstreams having too low distance bonus in SpeedEvaluator
#29994
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this PR - #27303
There's a major flaw introduced by this change - #15758
It comes from oversight of how
TravelDistance
andMinimalJumpDistance
workTravelDistance
is minimal distance you need to move to complete the slider. Equals to 0 on too short sliders.MinimalJumpDistance
is a distance from sliderend to the next object minus followcircle radius. This means that if distance to next object is too low - it will be also equal to 0.This makes practically all sliderstreams have 0 distance bonus.
Unfortunately fixing this issue buffs many farm maps. Specifically - patterns consecutive bursts bursts with sliders inbetween. It used to be worth much less than normal consecutive bursts, because it was assumed that there was no spacing inbetween bursts. Now it's still worth less, but not so much (nerfed only by rhythm).
The flaw is demonstrated the best here:
osu.2024-09-25.16-13-18-997.mp4
osu.2024-09-25.16-13-48-928.mp4