Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sliderstreams having too low distance bonus in SpeedEvaluator #29994

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Givikap120
Copy link
Contributor

Part of this PR - #27303

There's a major flaw introduced by this change - #15758
It comes from oversight of how TravelDistance and MinimalJumpDistance work
TravelDistance is minimal distance you need to move to complete the slider. Equals to 0 on too short sliders.
MinimalJumpDistance is a distance from sliderend to the next object minus followcircle radius. This means that if distance to next object is too low - it will be also equal to 0.
This makes practically all sliderstreams have 0 distance bonus.

Unfortunately fixing this issue buffs many farm maps. Specifically - patterns consecutive bursts bursts with sliders inbetween. It used to be worth much less than normal consecutive bursts, because it was assumed that there was no spacing inbetween bursts. Now it's still worth less, but not so much (nerfed only by rhythm).

The flaw is demonstrated the best here:

osu.2024-09-25.16-13-18-997.mp4
osu.2024-09-25.16-13-48-928.mp4

Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Videos are broken
  2. Sliderstreams should not have any distance to begin with, unless of course you're supposed to actually move the cursor to properly complete every slider

@Givikap120
Copy link
Contributor Author

  1. Videos are broken
  2. Sliderstreams should not have any distance to begin with, unless of course you're supposed to actually move the cursor to properly complete every slider
  1. How the videos are broken? On videos you can see that converting sliderstream to normal stream is increasing pp reward in 2 times.
  2. Sliderstreams calculated to have 0 spacing between the two heads, even if they're spaced streams in reality.

@stanriders
Copy link
Member

Oh nevermind videos are back again, github returned 404 before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants