Change wording on search results info text when no search term is entered #30442
Conversation
|
Comparison images for reference, top is post PR bottom is live
|
|
|
||
| if (FilterControl.CurrentTextSearch.Value == string.Empty) | ||
| { | ||
| FilterControl.InformationalText = $"{carouselCountDisplayed} beatmaps available"; |
There was a problem hiding this comment.
This brings back the terminology conflict in #23000 (comment) (first run setup counting "beatmaps" and song select counting "beatmap difficulties", which was maybe too long a label that it had to be changed to be ambiguous).
Can be X available, but that looks wrong.
There was a problem hiding this comment.
Ah I see, if anything shouldn't the first run import text be changed? Either changing the text to say "mapsets" or changing the number to match stable "beatmaps" would work. The disparity between the import number and the number I got in the stable dialogue is quite confusing irrespective of this change so a change there would be beneficial anyway.
There was a problem hiding this comment.
Based on https://osu.ppy.sh/wiki/en/Beatmap, stable wording is wrong. Also, the term "mapsets" is rarely used in the wiki.
I just want consistency in wiki, lazer/stable, and web.
Edit: To answer your question, users may want to see the "beatmap" (wiki definition) number, so I don't think that should be changed.
There was a problem hiding this comment.
Should it not just read X matching difficulties if we want it to be more explicit? Also I don't get why it becomes "matches" when filtering.
There was a problem hiding this comment.
Yes, I'm fine with that and X difficulties available/X available difficulties if what you believe in #23000 (comment) (with words just swapped) changed.
@jhk2601 this new string also doesn't account for plurality.
And search is not the only filter. This PR doesn't take account of the difficulty range, collections, ruleset, conversion, etc. For example, if the difficulty range is modified, should it say X available difficulties or X matching difficulties? Right now, it says the former.
There was a problem hiding this comment.
hmm this is a great point, the "available difficulties" text in stable appeared on the main menu which avoided similar concerns. Might just close this and open a discussion since its less of an "easy fix" than I imagined, moving away from "matches" altogether somehow might be a better idea..
The wording "X matches" being used when you didn't search for anything always bothered me, this also matches stable (though in stable the X beatmaps available text is in a different location).