Fix occasional flash when quick exiting / retrying from player #30623
Conversation
peppy
changed the title
peppy
force-pushed
the
fix-flash-transition-player
branch
3 times, most recently
from
b0e5d5e
to
78a8d58
Compare
The gist of the issue is that `fadeOut` was being called *twice* in the quick exit/retry scenarios, causing weirdness with transforms. I've restructured things to ensure it's only called once.
peppy
force-pushed
the
fix-flash-transition-player
branch
from
78a8d58
to
afeb138
Compare
|
How do I test that this does what it says? Do I need to? |
If you just want to confirm that this fixes the double-fadeOut call you can place a breakpoint in You could also try adjusting the values of the fadeout to repro the flash I was seeing, but maybe not worth it and just trust that I can no longer reproduce it. May be single thread only. |
|
Code seems fine now, that said, I'm gonna be a pain in the ass about this, and say that... this seems visually worse somehow? master: 2024-11-14.15-21-16.mp4this PR: 2024-11-14.15-19-39.mp4Look at the playfield border specifically. It's doing this weird choppy fade now, rather than the smooth fade it is doing on master. I'm guessing that'll be caused by |
|
That seems wrong. I'll re-check. |
The gist of the issue is that
fadeOutwas being called twice in the quick exit/retry scenarios, causing weirdness with transforms.I've restructured things to ensure it's only called once.