Add missing mania tooltip overlay for 4k and 7k #31084
Conversation
…ariant display Use existing localisation strings from BeatmapsStrings instead of CommonStrings for consistent localisation handling
|
Hi, I have made the requested changes.
|
There was a problem hiding this comment.
Forgot to mention this, but contributors are expected to fix the code quality issues listed below in the checks.
The anchor doesn't seem to match web's tooltip. Can probably apply this to all tooltips:
diff --git a/osu.Game/Graphics/Cursor/OsuTooltipContainer.cs b/osu.Game/Graphics/Cursor/OsuTooltipContainer.cs
index 0d36cc1d08..4180825a8d 100644
--- a/osu.Game/Graphics/Cursor/OsuTooltipContainer.cs
+++ b/osu.Game/Graphics/Cursor/OsuTooltipContainer.cs
@@ -80,6 +80,7 @@ public OsuTooltip()
Margin = new MarginPadding(5),
AutoSizeAxes = Axes.Both,
MaximumSize = new Vector2(max_width, float.PositiveInfinity),
+ TextAnchor = Anchor.TopCentre,
}
};
}
as web also defaults to TopCentre everywhere.
|
Got it, thanks. I have added the text anchor for the tooltip. |
- Properly annotate things as nullable - Remove weird passthrough property (more on that later)
Localisable strings cannot be plainly interpolated or joined. That is a lossy operation that loses data.
This reverts commit c0b6e78. The change affects editor and other stuff and I'm not sure it's correct. It's not like client needs to match the appearance really. It already doesn't in many places.
|
I've done things to get this in. Notably the model was wonky (some things nullable that shouldn't have been, and some things non-nullable that should have been) and the localisation was broken. I've also reverted the tooltip change as I find it disputable and I don't think it matters enough anyway because the client design is already not matching web in several respects. |
Attempts to fix #30827 by adding osu!mania 4K/7K rank breakdowns to profile overlay tooltips, matching the behavior on the osu! website.
Changes:
The implementation follows the web version's data structure, using the variants field from the API response to show individual rankings for each key mode.
Testing: