Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve osu!mania playability on mobile devices #31368

Merged
merged 27 commits into from
Feb 1, 2025
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
7563a18
Allow locking orientation on iOS in certain circumstances
frenzibyte Dec 24, 2024
9d08bc2
Improve osu!mania gameplay scaling on portrait orientation
frenzibyte Dec 29, 2024
d7e4038
Keep game in portrait mode when restarting
frenzibyte Dec 30, 2024
0cd7f1b
Abstractify orientation handling and add Android support
frenzibyte Dec 30, 2024
1e08b3d
Make mania judgements relative to the hit target position
frenzibyte Dec 30, 2024
bea61d2
Replace `ManiaTouchInputArea` with touchable columns
frenzibyte Dec 31, 2024
64e557d
Simplify portrait check
frenzibyte Jan 1, 2025
e5713e5
Fix triangles judgement mispositioned on a miss
frenzibyte Jan 1, 2025
2138982
Fix player no longer handling non-loaded beatmaps
frenzibyte Jan 4, 2025
a241d1f
Fix `DrawableManiaRuleset` not cached as itself in subtypes
frenzibyte Jan 4, 2025
f121b03
Merge branch 'master' into mobile-fix-mania
frenzibyte Jan 12, 2025
f718696
Allow landscape orientation on tablet devices in osu!mania
frenzibyte Jan 12, 2025
c1ac27d
Fix failing tests
frenzibyte Jan 13, 2025
4774d9c
Fix mania fade in test not actually testing the mod
frenzibyte Jan 13, 2025
42e5cb5
Merge branch 'master' into mobile-fix-mania
peppy Jan 16, 2025
daa7921
Mark `IsTablet` with `new` to avoid inspection
peppy Jan 17, 2025
6ec7183
Revert "Fix triangles judgement mispositioned on a miss"
frenzibyte Jan 21, 2025
b63d941
Reapply "Fix triangles judgement mispositioned on a miss"
frenzibyte Jan 21, 2025
56a611b
Merge branch 'master' into mobile-fix-mania
peppy Jan 24, 2025
dac7d21
Be explicit on nullability in `RequiresPortraitOrientation`
frenzibyte Jan 25, 2025
8151c30
Revert unnecessary inheritance
frenzibyte Jan 25, 2025
ffc37ce
Avoid extra unnecessary DI
frenzibyte Jan 25, 2025
bb7daae
Simplify orientation locking code magnificently
frenzibyte Jan 26, 2025
c18128e
Remove `OrientationManager` and the entire mobile namespace
frenzibyte Jan 26, 2025
e8d20fb
Fix skin `SourceChanged` event never being unbound
peppy Jan 29, 2025
64b6725
Enable NRT on `Column`
frenzibyte Jan 30, 2025
cc3bb59
Remove pointless comment
peppy Feb 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Be explicit on nullability in RequiresPortraitOrientation
Co-authored-by: Dean Herbert <pe@ppy.sh>
frenzibyte and peppy committed Jan 26, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit dac7d21302cbd9b7094ba7fc0d5989a9f254d46d
11 changes: 10 additions & 1 deletion osu.Game/Screens/Play/Player.cs
Original file line number Diff line number Diff line change
@@ -68,7 +68,16 @@ public abstract partial class Player : ScreenWithBeatmapBackground, ISamplePlayb

public override bool HideMenuCursorOnNonMouseInput => true;

public override bool RequiresPortraitOrientation => DrawableRuleset?.RequiresPortraitOrientation == true;
public override bool RequiresPortraitOrientation
{
get
{
if (!LoadedBeatmapSuccessfully)
return false;

return DrawableRuleset!.RequiresPortraitOrientation;
}
}

protected override OverlayActivation InitialOverlayActivationMode => OverlayActivation.UserTriggered;