-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Penalise the reading difficulty of high velocity notes using "note density" #31512
Merged
stanriders
merged 8 commits into
ppy:pp-dev
from
buyaspacecube:high-vel-density-penalty
Jan 18, 2025
Merged
Penalise the reading difficulty of high velocity notes using "note density" #31512
stanriders
merged 8 commits into
ppy:pp-dev
from
buyaspacecube:high-vel-density-penalty
Jan 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lawtrohux
suggested changes
Jan 14, 2025
osu.Game.Rulesets.Taiko/Difficulty/Evaluators/ReadingEvaluator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Evaluators/ReadingEvaluator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Evaluators/ReadingEvaluator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Evaluators/ReadingEvaluator.cs
Outdated
Show resolved
Hide resolved
@ppy/pp-maintainers could we please get a smoogisheet for this? |
!diffcalc |
Lawtrohux
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, reasonable changes that will prevent issues down the line in addition.
stanriders
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note density refers to how close a note object is to the previous note object, relative to the spacing of base SV 1/4 notes. Pictured below is notes at 1.0 density (top), 0.667 density (middle) and 0.9 with 1.35 mixed in (bottom).
High velocity notes are generally agreed to be easier to read at higher density than lower, making the reading difficulty awarded by some maps with DT unreasonably high. These changes penalise the reading difficulty of high velocity notes at higher densities according to this curve: https://www.desmos.com/calculator/u63f3ntdsi
Some notable SR changes:
XHRONOXAPSULE [HEAVENLY] +DT: 10.36 -> 10.11
Kyouki Chinden [The End] +DT: 10.59 -> 10.37
This Little Girl (Nightcore Amen Edit) [Murder Oni] +DT: 9.87 -> 9.69
No change to SR +HR on any of these maps