Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penalise the reading difficulty of high velocity notes using "note density" #31512

Merged
merged 8 commits into from
Jan 18, 2025

Conversation

buyaspacecube
Copy link

@buyaspacecube buyaspacecube commented Jan 14, 2025

Note density refers to how close a note object is to the previous note object, relative to the spacing of base SV 1/4 notes. Pictured below is notes at 1.0 density (top), 0.667 density (middle) and 0.9 with 1.35 mixed in (bottom).

screenshot473

High velocity notes are generally agreed to be easier to read at higher density than lower, making the reading difficulty awarded by some maps with DT unreasonably high. These changes penalise the reading difficulty of high velocity notes at higher densities according to this curve: https://www.desmos.com/calculator/u63f3ntdsi

Some notable SR changes:
XHRONOXAPSULE [HEAVENLY] +DT: 10.36 -> 10.11
Kyouki Chinden [The End] +DT: 10.59 -> 10.37
This Little Girl (Nightcore Amen Edit) [Murder Oni] +DT: 9.87 -> 9.69
No change to SR +HR on any of these maps

@Lawtrohux Lawtrohux requested a review from a team January 14, 2025 14:36
@Lawtrohux Lawtrohux requested a review from a team January 15, 2025 04:06
@Lawtrohux
Copy link
Member

@ppy/pp-maintainers could we please get a smoogisheet for this?

@tsunyoku
Copy link
Member

!diffcalc
RULESET=taiko
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#31512

Copy link

Copy link
Member

@Lawtrohux Lawtrohux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, reasonable changes that will prevent issues down the line in addition.

@stanriders stanriders enabled auto-merge (squash) January 18, 2025 13:11
@stanriders stanriders merged commit 8354cd5 into ppy:pp-dev Jan 18, 2025
7 of 8 checks passed
@buyaspacecube buyaspacecube deleted the high-vel-density-penalty branch January 20, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Deploy
Development

Successfully merging this pull request may close these issues.

4 participants