Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move error function from osu.Game.Utils to osu.Game.Rulesets.Difficulty.Utils #31520

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

Natelytle
Copy link
Contributor

This is only ever going to be used for difficulty calculation anyway, so we might as well keep all diffcalc related files in one spot.

@peppy
Copy link
Member

peppy commented Jan 15, 2025

Please squash your commits (force pushing is fine). We don't need such commit messages in history thanks.

To clarify, force pushing is preferred to stupid commits if no one has reviewed the PR yet.

@stanriders
Copy link
Member

Please squash your commits (force pushing is fine). We don't need such commit messages in history thanks.

To clarify, force pushing is preferred to stupid commits if no one has reviewed the PR yet.

pp-dev merging policy is squash-only

Copy link
Member

@tsunyoku tsunyoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filename of the error function file should be a bit clearer to the fact it belongs to the DifficultyCalculationUtils class. Following general partial class naming conventions, could we rename to DifficultyCalculationUtils_ErrorFunction.cs?

Otherwise looks good.

@tsunyoku tsunyoku enabled auto-merge (squash) January 17, 2025 10:15
@tsunyoku tsunyoku merged commit 5b4ba92 into ppy:pp-dev Jan 17, 2025
7 of 8 checks passed
@Natelytle Natelytle deleted the move-error-function branch January 18, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Deploy
Development

Successfully merging this pull request may close these issues.

4 participants