Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiplayer not joining correct chat channel #32217

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Mar 4, 2025

Fixes #32216
Regressed in #31637

Requires a redeploy of osu-server-spectator with ppy/osu-server-spectator#275 and this change included.

@peppy
Copy link
Member

peppy commented Mar 4, 2025

It's worth adding a p0 and potentially also next-release tag to these kinds of issues (because we can't do a release without this else we will regress).

(ah it's on the issue..)

@peppy peppy added priority:0 Showstopper. Critical to the next release. next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Mar 4, 2025
@peppy peppy self-requested a review March 4, 2025 07:10
@peppy peppy merged commit 667bd6e into ppy:master Mar 4, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:multiplayer next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! priority:0 Showstopper. Critical to the next release. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiplayer does not join the correct chat channel
2 participants