Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block input to ruleset container on fail #3616

Closed
wants to merge 2 commits into from
Closed

Block input to ruleset container on fail #3616

wants to merge 2 commits into from

Conversation

plankp
Copy link
Contributor

@plankp plankp commented Oct 18, 2018

Fix #3603

@peppy
Copy link
Member

peppy commented Oct 28, 2018

Have you tried fixing this by instead making the fail overlay handle (and block) all events? basically add an override for OnEvent instead of the currently limited individual blocking overrides (see https://github.com/ppy/osu/blob/master/osu.Game/Screens/Play/GameplayMenuOverlay.cs#L157).

@plankp
Copy link
Contributor Author

plankp commented Oct 28, 2018

I have not tried, I will try it later. I only did it through parent input because that’s what how pause did it.

@plankp
Copy link
Contributor Author

plankp commented Oct 29, 2018

I couldn't get it to work(, but then it might have been because I was trying the wrong thing?)

@smoogipoo
Copy link
Contributor

Yikes, it seems like PassThroughInputManagers bypass the whole Handle() stuff when they sync the input in their Update().

This should like partly a framework bug, but Handle() should be the way to go here imo.

@smoogipoo
Copy link
Contributor

See: ppy/osu-framework#1966

@frenzibyte
Copy link
Member

Can be closed as it's outdated

@frenzibyte frenzibyte mentioned this pull request Jun 18, 2019
6 tasks
@plankp plankp closed this Jun 18, 2019
@plankp plankp deleted the block-input-on-fail branch June 18, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After failed map key overlay still counts key clicks
4 participants