Ensure beatmap is not disabled before continuing with present #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
requested changes
Feb 25, 2019
smoogipoo
reviewed
Feb 26, 2019
smoogipoo
previously requested changes
Feb 26, 2019
Co-Authored-By: peppy <pe@ppy.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4312.
Note that we can also fix this at the song select end, and may want to. PRing this for discussion.
Also note that the scenario pointed out in the related issue is a bit of a weird one. Clicking the button on the beatmap overlay should probably not work during multiplayer, or be blocked in some form.