Taiko Playfield Implementation #517

smoogipoo · 2017-03-21T07:43:58Z

Prereqs:

Add TaikoJudgementInfo. #514

Also completes #518.

Allows derivers to define the Content container in the constructor, to redirect the positioning of the HitObjects container.

Subtle but looks good imo (checked with flyte).

smoogipoo · 2017-03-21T08:51:23Z

HitTarget redesigned - this is now in a complete state.

osu.Game.Modes.Taiko/UI/HitTarget.cs

@@ -14,6 +14,7 @@ internal class HitTarget : Container
    {
        private const float normal_diameter = TaikoHitObject.CIRCLE_RADIUS * 2 * TaikoPlayfield.PLAYFIELD_SCALE;
        private const float finisher_diameter = normal_diameter * 1.5f;
+        private const float border_offset = 1;


osu.Desktop.VisualTests/Tests/TestCaseTaikoPlayfield.cs

+
+            protected override void Update()
+            {
+                // Doesn't move


peppy · 2017-03-21T14:05:51Z

able to rebase this off upstream master? still got diff lines from TaikoJudgementInfo

osu.Game.Modes.Taiko/UI/InputDrum.cs

+            /// [0] => Inner key, [1] => Outer key
+            /// </para>
+            /// </summary>
+            public List<Key> Keys = new List<Key>();


osu.Game.Modes.Taiko/UI/TaikoPlayfield.cs

+        private Container<JudgementText> judgementContainer;
+
+        private Container hitObjectContainer;
+        // ReSharper disable once NotAccessedField.Local


osu.Game.Modes.Taiko/UI/RingExplosion.cs

+    /// <summary>
+    /// A ring that explodes to indicate a judgement has occurred.
+    /// </summary>
+    internal class RingExplosion : CircularContainer


osu.Game.Modes.Taiko/UI/RingExplosion.cs

+        /// <summary>
+        /// The Judgement to display.
+        /// </summary>
+        public TaikoJudgementInfo Judgement;


…displays better at lower resolutions).

osu.Game/Modes/Judgements/DrawableJudgementInfo.cs

@@ -25,6 +25,8 @@ public class DrawableJudgementInfo<TJudgement> : Container

        protected readonly SpriteText JudgementText;

+        protected double HitVisibleLength => 600;


smoogipoo · 2017-03-23T06:43:56Z

:best:

smoogipoo added 10 commits March 21, 2017 14:53

Late-add the HitObjects container in the Playfield.

58be454

Allows derivers to define the Content container in the constructor, to redirect the positioning of the HitObjects container.

Add taiko playfield.

27a21cd

Move TaikoPlayfield to separate file.

10ed6ef

Merge branch 'taiko_judgement_scoring' into taiko_playfield_2

9b5cb7e

Add explosion rings.

4c398b1

Add judgement texts.

1ac9898

Add license + general fixes.

4e7a44c

Redesign HitTarget.

eec4a1b

Increase RingExplosion base size for finishers.

60e866a

Subtle but looks good imo (checked with flyte).

Remove now unnecessary field.

2cfab75

smoogipoo changed the title ~~Taiko playfield 2~~ Taiko Playfield Implementation Mar 21, 2017

smoogipoo added 2 commits March 21, 2017 17:55

10% chance to get finisher hits in testcase.

aac4f24

Add a 1px offset for the playfield border.

7cb2377

peppy reviewed Mar 21, 2017

View reviewed changes

smoogipoo added 2 commits March 21, 2017 18:26

Add comments.

e2b510f

Reduce some container nesting.

259ed03

peppy reviewed Mar 21, 2017

View reviewed changes

osu.Desktop.VisualTests/Tests/TestCaseTaikoPlayfield.cs Outdated

protected override void Update()

{

// Doesn't move

This comment was marked as off-topic.

Sign in to view

smoogipoo added 6 commits March 22, 2017 01:38

Merge remote-tracking branch 'origin/master' into taiko_playfield_2

afcd42b

Update framework.

b769c43

Fix post-merge errors.

e7a9307

Override is unnecessary.

8f6cee2

Merge remote-tracking branch 'origin/master' into taiko_playfield_2

790997d

Cleanups + fix CircularContainer usages.

9c325dd

smoogipoo closed this Mar 23, 2017

smoogipoo deleted the taiko_playfield_2 branch March 23, 2017 01:33

smoogipoo restored the taiko_playfield_2 branch March 23, 2017 01:33

smoogipoo reopened this Mar 23, 2017

smoogipoo added this to the taiko milestone Mar 23, 2017

Merge branch 'master' into taiko_playfield_2

2c580f4

peppy reviewed Mar 23, 2017

View reviewed changes

osu.Game.Modes.Taiko/UI/InputDrum.cs Outdated

/// [0] => Inner key, [1] => Outer key

/// </para>

/// </summary>

public List<Key> Keys = new List<Key>();

This comment was marked as off-topic.

Sign in to view

Add a way to get the score string from JugementInfo.

8b71d70

peppy reviewed Mar 23, 2017

View reviewed changes

smoogipoo added 3 commits March 23, 2017 12:49

Make judgement text generic to be used between game modes.

c9fe9e6

Reimplement JudgementText with the new DrawableJudgementInfo.

39ff026

Renaming + don't use List.

7f33e10

peppy reviewed Mar 23, 2017

View reviewed changes

osu.Game.Modes.Taiko/UI/RingExplosion.cs Outdated

/// <summary>

/// A ring that explodes to indicate a judgement has occurred.

/// </summary>

internal class RingExplosion : CircularContainer

This comment was marked as off-topic.

Sign in to view

Comment out unused container for now.

00054f1

peppy reviewed Mar 23, 2017

View reviewed changes

osu.Game.Modes.Taiko/UI/RingExplosion.cs Outdated

/// <summary>

/// The Judgement to display.

/// </summary>

public TaikoJudgementInfo Judgement;

This comment was marked as off-topic.

Sign in to view

smoogipoo and others added 11 commits March 23, 2017 13:02

s/Ring/Hit + privatize Judgement inside RingExplosion.

cedcab1

Fix usings.

aa2b22f

Fix some lone newlines.

8e1eef2

Merge branch 'master' into taiko_playfield_2

d441114

Add readonly attributes.

9a3fd8b

JudgementText -> DrawableTaikoJudgementInfo.

acfa4a4

Tidy up and tweak transitions of DrawableJudgementInfo.

02fba00

HitExplosion -> DrawableOsuJudgementInfo.

b83db18

Remove cross-reference to osu.Game.Modes.Osu from Taiko.

1af17fc

Adjust InputDrum's appearance a touch.

ef8830a

Add constant for HitTarget line thickness and make slightly thicker (…

ebb64e0

…displays better at lower resolutions).

smoogipoo commented Mar 23, 2017

View reviewed changes

Remove unused variable.

0863efb

smoogipoo merged commit cb51256 into ppy:master Mar 23, 2017

smoogipoo deleted the taiko_playfield_2 branch March 24, 2017 05:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Taiko Playfield Implementation #517

Taiko Playfield Implementation #517

smoogipoo commented Mar 21, 2017 •

edited by peppy

Loading

smoogipoo commented Mar 21, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

peppy commented Mar 21, 2017 •

edited

Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

smoogipoo commented Mar 23, 2017

		@@ -25,6 +25,8 @@ public class DrawableJudgementInfo<TJudgement> : Container

		protected readonly SpriteText JudgementText;

		protected double HitVisibleLength => 600;

Taiko Playfield Implementation #517

Taiko Playfield Implementation #517

Conversation

smoogipoo commented Mar 21, 2017 • edited by peppy Loading

smoogipoo commented Mar 21, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

peppy commented Mar 21, 2017 • edited Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

smoogipoo commented Mar 23, 2017

smoogipoo commented Mar 21, 2017 •

edited by peppy

Loading

peppy commented Mar 21, 2017 •

edited

Loading