-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fallback for humanizer localization lookup failures #5530
Conversation
There has to be a better way of doing this, because what you've done here is not going to handle all humanizer cases... E.g. you've missed |
Also please give links tracking the aforementioned issues, xamarin and/or humanizer. |
We can also potentially initialize a list of loaded localizations for humanizer at startup and checking against those instead, which would allow us to implement our own |
Have you tried including the package reference in the android project? Humanizr/Humanizer#380 (comment) |
yes, thats the first thing I tried actually. |
This needs some kind of resolution. |
Going with this for now as a "don't have a better idea" temporary fix. |
Fixes #5279
At the moment, there seems to be some internal failure on Xamarin/Mono/Humanizer's part to do two things:
In either case, it might be good to have a local fallback, so this PR introduces a helper function that catches exceptions thrown by humanizer that are a result of a failure to find a localization.
This was tested on an Android device and seems to be working fine.