-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust minor BeatmapSetOverlay details to better match osu-web #7730
Conversation
Note: due to osu-web using flex to even out the spacing and me not being able to implement the same behaviour here, I added a static margin to separate the title from the diffname above. This looks better than the previous state in most cases, the only scenario where this differs somehow visibly from web is on mapsets with large numbers of difficulties.
Please use |
Sorry, I couldn't run InspectCode because of some issues with PowerShell on my PC. Will start doing that as soon as I solve them. |
Removed mentioned parts, will create separate PRs for them later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, always match osu-web sizings
size 10 is unreadable due to the font rendering issues in general, if you take a look at the rest of the overlay, most elements use fonts (or overall dimensions) a few px bigger than web and I followed that direction - it seems correct because matching osu-web 1:1 here looks way more off (I suppose due to some scaling behaviour I can't properly explain) and font sizes like 10px are unreadable due to how lazer renders them in overlays. currently used font sizes make the overlay look much closer to osu-web than if we used 1:1 font sizes. |
Match the font sizes. We can uniformly apply a scale at a later point if needed, inside |
Then we'd have to change every single overlay element / font since they're mostly sized a tad bigger than osu-web. |
That's correct. |
Alright, I'll try to work on it, I'm not sure how that's gonna end up looking though. |
It will look fine. All metrics should match (font sizes, widths, paddings, margins). Overall adjustments can be applied later on when we decide how large or small we want things to display. The important part is that everything matches on a numeric and relative basis so it is easy to confirm correctness without manually pixel checking (aka what you've probably been doing until now). |
Went back to osu-web font size values as suggested. I'll make a separate PR soon which will aim to bring all the dimensions / sizes 1:1 with osu-web. |
Comparisons to null of nullable numbers are always false.
I fixed up a few remaining nits; looks fine otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this PR has run its course - I'd say let's get it in for now. Accuracy with web can be iterated on.
Follows #7724, aims to bring the
BeatmapSetOverlay
even closer to its osu-web counterpart. These changes are mostly small details, but they definitely can affect the UX.A few things worth noting:
TopScoreStatisticsSection
(as mentioned in #7725), I applied a similar solution, but I'm not sure if it's the proper one here. maybe instead of this we should sort them before they get passed to any UI components?