Change Metal fences to rely on GPU-side signals instead #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
peppy
reviewed
Jul 9, 2023
peppy
reviewed
Jul 9, 2023
peppy
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency for getting rid of all the mutex locks surrounding
MTLCommandBuffercompletion handler, and potentially getting rid of the completion handler altogether.In Metal, there is an object which can be accessed & updated by both the CPU and the GPU, and this PR relies on that object to use for implementing fences instead. Works pretty efficiently, and on a 10 second run on sample game, there's about 12ms spent on reading the signal value by the CPU: