Skip to content

Commit

Permalink
FIPS202 ASM: Sync filenames and function symbol names
Browse files Browse the repository at this point in the history
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
  • Loading branch information
hanno-becker committed Oct 2, 2024
1 parent 958350f commit 3226337
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,11 @@ round_constants:

.text
.balign 16
.global keccak_f1600_x1_scalar_slothy_opt_a55
.global _keccak_f1600_x1_scalar_slothy_opt_a55
.global keccak_f1600_x1_scalar_asm_opt
.global _keccak_f1600_x1_scalar_asm_opt

keccak_f1600_x1_scalar_slothy_opt_a55:
_keccak_f1600_x1_scalar_slothy_opt_a55:
keccak_f1600_x1_scalar_asm_opt:
_keccak_f1600_x1_scalar_asm_opt:
alloc_stack
save_gprs

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -904,13 +904,13 @@ round_constants:
ror sAsu, sAsu,#(64-55)
.endm

.global keccak_f1600_x4_scalar_v8a_v84a_asm_hybrid_opt
.global _keccak_f1600_x4_scalar_v8a_v84a_asm_hybrid_opt
.global keccak_f1600_x4_scalar_v8a_v84a_hybrid_asm_opt
.global _keccak_f1600_x4_scalar_v8a_v84a_asm_hybrid_asm_opt
.text
.align 4

keccak_f1600_x4_scalar_v8a_v84a_asm_hybrid_opt:
_keccak_f1600_x4_scalar_v8a_v84a_asm_hybrid_opt:
keccak_f1600_x4_scalar_v8a_v84a_hybrid_asm_opt:
_keccak_f1600_x4_scalar_v8a_v84a_hybrid_asm_opt:
alloc_stack
save_gprs
save_vregs
Expand Down
4 changes: 2 additions & 2 deletions fips202/asm/asm.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
#include "config.h"

#ifdef MLKEM_USE_AARCH64_ASM
void keccak_f1600_x1_scalar_slothy_opt_a55(uint64_t *state);
void keccak_f1600_x1_scalar_asm_opt(uint64_t *state);
void keccak_f1600_x1_v84a_asm_clean(uint64_t *state);
void keccak_f1600_x2_v84a_asm_clean(uint64_t *state);
void keccak_f1600_x2_v8a_v84a_asm_hybrid(uint64_t *state);
void keccak_f1600_x4_scalar_v8a_asm_hybrid_opt(uint64_t *state);
void keccak_f1600_x4_scalar_v84a_asm_hybrid_opt(uint64_t *state);
void keccak_f1600_x4_scalar_v8a_v84a_asm_hybrid_opt(uint64_t *state);
void keccak_f1600_x4_scalar_v8a_v84a_hybrid_asm_opt(uint64_t *state);

/*
* The FIPS202 ASM profile decides which implementation(s) of FIPS202 to use.
Expand Down
2 changes: 1 addition & 1 deletion fips202/asm/profiles/cortex_a55.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
// On Cortex-A55, we use lazy rotation assembly for Keccak-x1,
// but no batched assembly implementation.
#define MLKEM_USE_FIPS202_X1_ASM
#define keccak_f1600_x1_asm keccak_f1600_x1_scalar_slothy_opt_a55
#define keccak_f1600_x1_asm keccak_f1600_x1_scalar_asm_opt

#endif /* FIPS202_ASM_PROFILE_H */
4 changes: 2 additions & 2 deletions fips202/asm/profiles/default.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#define keccak_f1600_x1_asm keccak_f1600_x1_v84a_asm_clean
#elif !defined(SYS_AARCH64_SLOW_BARREL_SHIFTER)
#define MLKEM_USE_FIPS202_X1_ASM
#define keccak_f1600_x1_asm keccak_f1600_x1_scalar_slothy_opt_a55
#define keccak_f1600_x1_asm keccak_f1600_x1_scalar_asm_opt
#endif /* !SYS_AARCH64_SLOW_BARREL_SHIFTER */

// Keccak-f1600x2/x4
Expand All @@ -50,7 +50,7 @@
#define keccak_f1600_x2_asm keccak_f1600_x2_v84a_asm_clean
#else /* __APPLE__ */
#define MLKEM_USE_FIPS202_X4_ASM
#define keccak_f1600_x4_asm keccak_f1600_x4_scalar_v8a_v84a_asm_hybrid_opt
#define keccak_f1600_x4_asm keccak_f1600_x4_scalar_v8a_v84a_hybrid_asm_opt
#endif /* __APPLE__ */

#else /* __ARM_FEATURE_SHA3 */
Expand Down

0 comments on commit 3226337

Please sign in to comment.