Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PKESKv6 PQC encryption case #66

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix PKESKv6 PQC encryption case #66

merged 1 commit into from
Apr 24, 2024

Conversation

TJ-91
Copy link
Collaborator

@TJ-91 TJ-91 commented Apr 24, 2024

Fixes #63

CLI Tests still have an error but I believe that's unrelated:

285: ERROR: test_zzz_encryption_and_signing_pqc (__main__.Encryption)
285: ----------------------------------------------------------------------
285: Traceback (most recent call last):
285:   File "/home/jroth/PQC_TB/rnp-dev/src/tests/cli_tests.py", line 4501, in test_zzz_encryption_and_signing_pqc
285:     signerpws = [passwds[i]]
285: IndexError: list index out of range
285: 

@falko-strenzke Should I still implement a unit test for PQC encryption (that would've caught this), or is it enough to have the CLI test now?

@falko-strenzke
Copy link
Contributor

Fixes #63

CLI Tests still have an error but I believe that's unrelated:

285: ERROR: test_zzz_encryption_and_signing_pqc (__main__.Encryption)
285: ----------------------------------------------------------------------
285: Traceback (most recent call last):
285:   File "/home/jroth/PQC_TB/rnp-dev/src/tests/cli_tests.py", line 4501, in test_zzz_encryption_and_signing_pqc
285:     signerpws = [passwds[i]]
285: IndexError: list index out of range
285: 

@falko-strenzke Should I still implement a unit test for PQC encryption (that would've caught this), or is it enough to have the CLI test now?

If we don't have a unit-test for pqc encryption, then yes, I think we should implement one.

@TJ-91 TJ-91 merged commit 81dc47c into pqc-cli-tests Apr 24, 2024
111 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants