feat: allow to check if a response is cacheable #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkweak
suggested changes
Dec 5, 2020
pquerna
reviewed
Dec 5, 2020
| @@ -109,10 +93,29 @@ func CachableObject(obj *Object, rv *ObjectResults) { | |||
| if obj.ReqDirectives != nil && obj.ReqDirectives.NoStore { | |||
| rv.OutReasons = append(rv.OutReasons, ReasonRequestNoStore) | |||
There was a problem hiding this comment.
shouldn't this also move to CachableResponseObject?
There was a problem hiding this comment.
I hesitated but I don't think so, it's related to the request, not to the response.
darkweak
suggested changes
Dec 5, 2020
Co-authored-by: Darkweak <sylvain@les-tilleuls.coop>
|
status on this? |
pquerna
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a cache module for Caddy server, and I need to check if the request will not be cacheable to prevent initializing some useless stuff. What do you think about allowing to do this with the library?