Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deprecated APIs #13

Closed
wants to merge 7 commits into from
Closed

Migrate deprecated APIs #13

wants to merge 7 commits into from

Conversation

Abdullah104
Copy link
Contributor

This commit removes the usage of deprecated APIs and migrates them to their corresponding updated API except for buttons API.

@pr-Mais pr-Mais changed the title Updating Used API Migrate deprecated API Dec 4, 2021
@pr-Mais pr-Mais changed the title Migrate deprecated API Migrate deprecated APIs Dec 4, 2021
@pr-Mais
Copy link
Owner

pr-Mais commented Dec 4, 2021

Thank you for your valuable contribution.
Seems LGTM yet I just need to verify that the changes haven't affected any widget

@pr-Mais
Copy link
Owner

pr-Mais commented Feb 15, 2022

I think most of these were fixed in #15 but wasn't merged, now it's merged, we can close it, sorry for confusion.
I'm just wondering about vsync: this, in Flutter 2.10 it seems like it's not deprecated anymore?

@pr-Mais pr-Mais closed this Feb 15, 2022
@Abdullah104
Copy link
Contributor Author

I checked the documentation. It seems like it's still deprecated inside the AnimatedSize widget constructor, but it's not deprecated for the animation controller.

@pr-Mais
Copy link
Owner

pr-Mais commented Feb 15, 2022

I see, thank you
that was also on #15, we're safe then :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants