-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🚀 upgrade SDK, deps, and fix any deprecations in the way + FVM #18
Merged
pr-Mais
merged 11 commits into
pr-Mais:main
from
YazeedAlKhalaf:chore/upgrade-deps-and-use-fvm
Aug 8, 2024
Merged
feat: 🚀 upgrade SDK, deps, and fix any deprecations in the way + FVM #18
pr-Mais
merged 11 commits into
pr-Mais:main
from
YazeedAlKhalaf:chore/upgrade-deps-and-use-fvm
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- path_provider, shared_preferences, url_launcher doesn't support iOS 11 anymore - freezed was left at 2.5.2 instead of 2.5.3 because of analyzer version issues
…s for both iOS and Android
YazeedAlKhalaf
commented
Jun 1, 2024
Comment on lines
+12
to
+13
MediaQueryData.fromView(WidgetsBinding.instance.window) | ||
.platformBrightness; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only remaining deprecation:
'window' is deprecated and shouldn't be used. Look up the current FlutterView from the context via View.of(context) or consult the PlatformDispatcher directly instead. Deprecated to prepare for the upcoming multi-window support. This feature was deprecated after v3.7.0-32.0.pre.
Try replacing the use of the deprecated member with the replacement.
pr-Mais
changed the title
🚀 Upgrade SDK, deps, and fix any deprecations in the way + FVM
feat: 🚀 upgrade SDK, deps, and fix any deprecations in the way + FVM
Aug 8, 2024
Thanks a ton Yazeed! this is a big and exciting PR, LGTM ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter version upgraded to is the latest stable as of today:
3.22.1
.This PR upgrades everything to the latest version possible, and it also includes
fvm
so that it is easier to have the same environment for contributors.Things I did in points, hopefully nothing is missing:
12.0
now, sincepath_provider
,shared_preferences
, andurl_launcher
don't support iOS11.0
anymoreflutter fix:
https://docs.flutter.dev/release/breaking-changes/3-19-deprecationsselectedRowColor
was deprecated in 3.16 and here is what I followed: https://docs.flutter.dev/release/breaking-changes/3-16-deprecations#themedata-selectedrowcolorflutter_local_notifications
android guide again for some changes: https://pub.dev/packages/flutter_local_notifications#-android-setup