Replace derive feature on serde with a separate serde_derive dependency #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serde past 1.0.184 doesn't have the binary blob anymore so it's safe to upgrade.
During the discussion about the binary blob it was pointed out serde-rs/serde#2584 that the
feature = ["derive"]onserdedependency causes a very long critical chain in the compilation causing a slowdown. I tried disabling the feature and includingserde_derive.On an 8 core CPU this was a huge boost. On my system the
--releasebuild time went from 21.8 seconds to just 8.7 seconds!Before:
After:
long timings graphs
Before:
After:
