Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual only mode (no nodes selected) #294

Closed
MelissaHoweEmis opened this issue Oct 19, 2022 · 3 comments · Fixed by #447
Closed

Visual only mode (no nodes selected) #294

MelissaHoweEmis opened this issue Oct 19, 2022 · 3 comments · Fixed by #447
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@MelissaHoweEmis
Copy link

Is your feature request related to a problem? Please describe.
Currently a node has to be active, I would like a visual only timeline where no node is highlighted

Describe the solution you'd like
For there to be a flag to set no node as selected

Describe alternatives you've considered
Tried setting disableClickOnCircle but the mouse still changes to a pointer when not clickable, and you still have a node set as active.

Additional context
For a more visual timeline to represent a history without the need to interact

@prabhuignoto prabhuignoto self-assigned this Oct 19, 2022
@prabhuignoto prabhuignoto added the enhancement New feature or request label Oct 19, 2022
@prabhuignoto
Copy link
Owner

@MelissaHoweEmis a new prop will be added to disable the interaction. A new minor release to fix this will be out soon.

@prabhuignoto
Copy link
Owner

@MelissaHoweEmis relooking at this request again. have you tried using the disableAutoScrollOnClick prop. Can you confirm if this solves the issue.

@prabhuignoto prabhuignoto added the question Further information is requested label Oct 21, 2022
@MelissaHoweEmis
Copy link
Author

Im afraid it doesnt solve the issue that when disableClickOnCircle and disableAutoScrollOnClick are set to true, the mouse cursor changes on hover of the nodes. When they aren't clickable I would assume the mouse wouldn't change. They also still have a role of button which implies they are clickable too, I would expect the role to be undefined when they are not interactive.

As an additiona, I think a prop of viewOnly or something similar to the entire timeline would be good as it means you cannot interact with any element of it, and no nodes are marked as selected.

@prabhuignoto prabhuignoto linked a pull request Jan 4, 2024 that will close this issue
8 tasks
@prabhuignoto prabhuignoto mentioned this issue Jan 4, 2024
8 tasks
prabhuignoto added a commit that referenced this issue Jan 7, 2024
 - Fix for #434 (onItemSelected does not work as expected)
 - Support for rendering HTML directly on the timeline cards (#443 )
 - New prop `disableRendering` to disable all interactions with the timeline (#294)
 - New prop `highlightCardsOnHover` that highlights cards on hover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants