Skip to content
CI

fix(deps): update rust crate serde to 1.0.188 #666

Sign in to view logs

fix(deps): update rust crate serde to 1.0.188

fix(deps): update rust crate serde to 1.0.188 #666

GitHub Actions / clippy succeeded Aug 21, 2023 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.71.1 (eb26296b5 2023-08-03)
  • cargo 1.71.1 (7f1d04c00 2023-07-29)
  • clippy 0.1.71 (eb26296 2023-08-03)

Annotations

Check warning on line 13 in src/server.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::net::TcpListener` 

warning: useless conversion to the same type: `std::net::TcpListener`
  --> src/server.rs:13:47
   |
13 |             tokio::net::TcpListener::from_std(listener.into()).unwrap(),
   |                                               ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `listener`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 55 in src/routes/posts.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
  --> src/routes/posts.rs:52:36
   |
52 |           res.render(Redirect::other(&format!(
   |  ____________________________________^
53 | |             "/posts/{}/{}",
54 | |             normalized_slug, attachment_name
55 | |         )));
   | |_________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
help: change this to
   |
52 ~         res.render(Redirect::other(format!(
53 +             "/posts/{}/{}",
54 +             normalized_slug, attachment_name
55 ~         )));
   |

Check warning on line 26 in src/routes/posts.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
  --> src/routes/posts.rs:26:40
   |
26 |         res.render(Redirect::permanent(&format!("/posts/{}/", normalized_slug)));
   |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("/posts/{}/", normalized_slug)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 137 in src/blog.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
   --> src/blog.rs:137:48
    |
137 |         let conf_contents = fs::read_to_string(&conf_path)?;
    |                                                ^^^^^^^^^^ help: change this to: `conf_path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default
View more details on GitHub Actions