embed quickpick.vim and add experimental quickpick support for codelens #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Cool!
|
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more details at mattn/vim-lsp-settings#368 (comment)
This introduces quickpick which can be used to fuzzy search and is lot easier to use than inputlist. quickpick.vim is similar to ctrlp/denite which I wrote in single vimscript similar to async.vim and callbag.vim which so that it can easily be embeded.
It is currently under
let lsp_experimental_quickpick_ui = 1since quickpick it self might be buggy. There are no docs yet since it is experimental feature refer to source code of quickpick which is currently 400 lines of code and very easy to navigate around. Use it at your own risk.I will make the quickpick more resuable and easier to use inside vim-lsp in the future so everyone doesnt' have to implement on_accept/on_cancel methods.
//cc @mattn