Vim8 popup scroll #1025
Closed
Vim8 popup scroll #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabirshrestha
requested changes
Jan 8, 2021
|
I'm going to wait for this change since it could be breaking. I'm hoping we can use hrsh7th/vim-vital-vs#3 instead.
|
|
I'm going to close this PR since we are in the middle of migrating to a new popup/floating window code and callbags. I would first suggest to migrate to it and then work on adding scrolling on top of it. The vital popup we are using has easy scroll apis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cf. #975)
Sorry this took a while!
I was keeping a tab on the discussion with Bram on focusing in Vim 8 popup windows. It doesn't seem like that will be implemented soon, so in the meantime I guess this might be a workable band-aid. I also added a
:LspPopupScrollcommand which exposes the functionality more easily. I did look intopopup_filter(), but I suspect implementing that would require slightly larger-scale modification of the existing codebase. Of course, if you choose to go down a different route in the future I am willing to help.