Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do not merge] add vital's experimental popup #1032

Closed
wants to merge 1 commit into from
Closed

[Do not merge] add vital's experimental popup #1032

wants to merge 1 commit into from

Conversation

prabirshrestha
Copy link
Owner

github-actions[bot]
github-actions bot reviewed Jan 9, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vint

autoload/vital/_popup/Experimental/UI/Popup.vim|76 col 42| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|78 col 21| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|84 col 7| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|85 col 7| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|87 col 29| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|89 col 24| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|94 col 7| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|95 col 15| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|97 col 30| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|97 col 65| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|99 col 27| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|99 col 61| Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|162 col 8| Make the scope explicit like l:key (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|162 col 13| Make the scope explicit like l:Cb (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|163 col 15| Make the scope explicit like l:key (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|164 col 18| Make the scope explicit like l:key (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|164 col 25| Make the scope explicit like l:Cb (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|217 col 7| Make the scope explicit like l:eventhandler (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|218 col 31| Make the scope explicit like l:eventhandler (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|219 col 26| Make the scope explicit like l:eventhandler (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/_popup/Experimental/UI/Popup.vim|223 col 5| Use the full option name cpoptions instead of cpo (see :help option-summary)
autoload/vital/popup.vim|23 col 7| Make the scope explicit like l:base (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|24 col 7| Make the scope explicit like l:base (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|25 col 10| Make the scope explicit like l:base (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|39 col 7| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|40 col 7| Make the scope explicit like l:functions (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|41 col 7| Make the scope explicit like l:a (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|42 col 13| Make the scope explicit like l:a (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|43 col 11| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|43 col 20| Make the scope explicit like l:a (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|44 col 17| Make the scope explicit like l:a (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|45 col 11| Make the scope explicit like l:functions (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|45 col 23| Make the scope explicit like l:a (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|47 col 11| Make the scope explicit like l:a (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|49 col 7| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|49 col 16| Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|50 col 12| Make the scope explicit like l:functions (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|51 col 17| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|51 col 25| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|53 col 9| Make the scope explicit like l:f (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|53 col 14| Make the scope explicit like l:functions (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|54 col 18| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|54 col 26| Make the scope explicit like l:f (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|54 col 41| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|54 col 49| Make the scope explicit like l:f (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|55 col 13| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|55 col 20| Make the scope explicit like l:f (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|55 col 25| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|55 col 32| Make the scope explicit like l:f (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|59 col 10| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|64 col 7| Make the scope explicit like l:arg (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|65 col 10| Make the scope explicit like l:name (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|65 col 16| Make the scope explicit like l:as (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|65 col 27| Make the scope explicit like l:arg (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|65 col 46| Make the scope explicit like l:arg (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|65 col 58| Make the scope explicit like l:arg (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|65 col 63| Make the scope explicit like l:arg (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|66 col 9| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|66 col 29| Make the scope explicit like l:as (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|67 col 9| Make the scope explicit like l:dict (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|67 col 16| Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|68 col 9| Make the scope explicit like l:dict_type (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|69 col 18| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|70 col 11| Make the scope explicit like l:ns (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|70 col 23| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|71 col 19| Make the scope explicit like l:dict (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|71 col 25| Make the scope explicit like l:ns (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|72 col 13| Make the scope explicit like l:dict (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|72 col 18| Make the scope explicit like l:ns (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|74 col 15| Make the scope explicit like l:dict (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|74 col 20| Make the scope explicit like l:ns (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|74 col 28| Make the scope explicit like l:dict_type (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|75 col 13| Make the scope explicit like l:dict (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|75 col 20| Make the scope explicit like l:dict (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|75 col 25| Make the scope explicit like l:ns (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|77 col 15| Make the scope explicit like l:dict (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|82 col 19| Make the scope explicit like l:dict (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|82 col 25| Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|82 col 38| Make the scope explicit like l:name (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|84 col 11| Make the scope explicit like l:arg (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|86 col 10| Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|106 col 7| Make the scope explicit like l:paths (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|106 col 43| Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|107 col 7| Make the scope explicit like l:modules (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|107 col 26| Make the scope explicit like l:paths (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|108 col 15| Make the scope explicit like l:modules (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|113 col 10| Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|118 col 7| Make the scope explicit like l:builtin (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|119 col 7| Make the scope explicit like l:installed (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|120 col 7| Make the scope explicit like l:base (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|120 col 14| Make the scope explicit like l:builtin (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|120 col 30| Make the scope explicit like l:installed (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|121 col 25| Make the scope explicit like l:base (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|125 col 7| Make the scope explicit like l:pattern (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|126 col 39| Make the scope explicit like l:pattern (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|130 col 7| Make the scope explicit like l:tr (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|131 col 7| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|132 col 7| Make the scope explicit like l:regexp (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|132 col 56| Make the scope explicit like l:target (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|133 col 36| Make the scope explicit like l:regexp (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|137 col 7| Make the scope explicit like l:filename (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|138 col 7| Make the scope explicit like l:tail (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|138 col 23| Make the scope explicit like l:filename (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|139 col 21| Make the scope explicit like l:tail (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|147 col 7| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|147 col 16| Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|148 col 14| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|149 col 10| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|149 col 32| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|151 col 7| Make the scope explicit like l:export_module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|151 col 35| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|155 col 26| Make the scope explicit like l:export_module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|156 col 14| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|158 col 12| Make the scope explicit like l:module (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|169 col 7| Make the scope explicit like l:funcs (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|170 col 7| Make the scope explicit like l:stack (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|171 col 7| Make the scope explicit like l:line (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|171 col 21| Make the scope explicit like l:stack (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|172 col 9| Make the scope explicit like l:m (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|172 col 23| Make the scope explicit like l:line (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|173 col 15| Make the scope explicit like l:m (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|174 col 12| Make the scope explicit like l:name (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|174 col 18| Make the scope explicit like l:lnum (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|174 col 24| Make the scope explicit like l:lnum2 (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|174 col 33| Make the scope explicit like l:m (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|175 col 16| Make the scope explicit like l:lnum (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|176 col 13| Make the scope explicit like l:lnum (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|176 col 20| Make the scope explicit like l:lnum2 (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|178 col 11| Make the scope explicit like l:info (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|178 col 35| Make the scope explicit like l:name (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|179 col 17| Make the scope explicit like l:info (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|180 col 13| Make the scope explicit like l:attrs (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|180 col 27| Make the scope explicit like l:info (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|180 col 58| Make the scope explicit like l:info (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|181 col 13| Make the scope explicit like l:flnum (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|181 col 21| Make the scope explicit like l:info (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|181 col 62| Make the scope explicit like l:info (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|181 col 74| Make the scope explicit like l:lnum (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|182 col 18| Make the scope explicit like l:funcs (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|183 col 18| Make the scope explicit like l:info (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|183 col 33| Make the scope explicit like l:attrs (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|183 col 40| Make the scope explicit like l:lnum (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|183 col 46| Make the scope explicit like l:info (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|183 col 61| Make the scope explicit like l:flnum (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|188 col 14| Make the scope explicit like l:funcs (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|188 col 21| Make the scope explicit like l:line (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|190 col 15| Make the scope explicit like l:funcs (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|194 col 7| Make the scope explicit like l:name (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|196 col 9| Make the scope explicit like l:name (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|198 col 9| Make the scope explicit like l:name (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|200 col 20| Make the scope explicit like l:name (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|203 col 7| Make the scope explicit like l:body (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|203 col 52| Make the scope explicit like l:name (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|204 col 7| Make the scope explicit like l:lines (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|204 col 21| Make the scope explicit like l:body (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|205 col 7| Make the scope explicit like l:signature (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|205 col 28| Make the scope explicit like l:lines (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|206 col 8| Make the scope explicit like l:_ (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|206 col 11| Make the scope explicit like l:file (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|206 col 17| Make the scope explicit like l:lnum (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|206 col 23| Make the scope explicit like l:__ (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|206 col 39| Make the scope explicit like l:lines (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|209 col 30| Make the scope explicit like l:file (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|210 col 19| Make the scope explicit like l:lnum (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|212 col 35| Make the scope explicit like l:signature (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|213 col 62| Make the scope explicit like l:signature (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|219 col 7| Make the scope explicit like l:funcname (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|219 col 38| Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|221 col 17| Make the scope explicit like l:funcname (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|243 col 7| Make the scope explicit like l:path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|244 col 20| Make the scope explicit like l:path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|247 col 7| Make the scope explicit like l:vital_dir (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|248 col 7| Make the scope explicit like l:base (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|248 col 20| Make the scope explicit like l:vital_dir (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|249 col 7| Make the scope explicit like l:p (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|249 col 11| Make the scope explicit like l:base (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|250 col 7| Make the scope explicit like l:sid (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|250 col 20| Make the scope explicit like l:path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|250 col 26| Make the scope explicit like l:p (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|251 col 7| Make the scope explicit like l:sid (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|252 col 20| Make the scope explicit like l:path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|253 col 9| Make the scope explicit like l:sid (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|253 col 22| Make the scope explicit like l:path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|253 col 28| Make the scope explicit like l:p (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|254 col 9| Make the scope explicit like l:sid (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|255 col 61| Make the scope explicit like l:path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|258 col 10| Make the scope explicit like l:sid (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|266 col 27| Use the full option name runtimepath instead of rtp (see :help option-summary)
autoload/vital/popup.vim|280 col 7| Make the scope explicit like l:unified_path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|281 col 27| Make the scope explicit like l:unified_path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|282 col 24| Make the scope explicit like l:unified_path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|284 col 7| Make the scope explicit like l:line (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|285 col 10| Make the scope explicit like l:_ (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|285 col 13| Make the scope explicit like l:sid (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|285 col 18| Make the scope explicit like l:path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|285 col 24| Make the scope explicit like l:__ (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|285 col 40| Make the scope explicit like l:line (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|286 col 22| Make the scope explicit like l:path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|286 col 32| Make the scope explicit like l:unified_path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|287 col 23| Make the scope explicit like l:unified_path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|287 col 39| Make the scope explicit like l:sid (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|288 col 26| Make the scope explicit like l:unified_path (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|304 col 9| Make the scope explicit like l:value (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|306 col 39| Make the scope explicit like l:value (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|307 col 12| Make the scope explicit like l:value (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|318 col 7| Make the scope explicit like l:fs (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|319 col 7| Make the scope explicit like l:r (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|320 col 7| Make the scope explicit like l:pattern (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|321 col 7| Make the scope explicit like l:fname (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|321 col 20| Make the scope explicit like l:fs (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|321 col 40| Make the scope explicit like l:pattern (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|322 col 9| Make the scope explicit like l:r (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|322 col 11| Make the scope explicit like l:fname (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|322 col 49| Make the scope explicit like l:fname (see Anti-pattern of vimrc (Scope of identifier))
autoload/vital/popup.vim|324 col 10| Make the scope explicit like l:r (see Anti-pattern of vimrc (Scope of identifier))

autoload/vital/_popup/Experimental/UI/Popup.vim
execute join(['function! vital#_popup#Experimental#UI#Popup#import() abort', printf("return map({'options': '', 'bufnr': '', 'hide': '', 'create': '', 'show': '', 'is_supported': '', 'close': '', 'winid': '', 'contents': ''}, \"vital#_popup#function('<SNR>%s_' . v:key)\")", s:_SID()), 'endfunction'], "\n")
delfunction s:_SID
" ___vital___
let s:save_cpo = &cpo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Use the full option name cpoptions instead of cpo (see :help option-summary)

autoload/vital/_popup/Experimental/UI/Popup.vim
delfunction s:_SID
" ___vital___
let s:save_cpo = &cpo
set cpo&vim
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Use the full option name cpoptions instead of cpo (see :help option-summary)

autoload/vital/_popup/Experimental/UI/Popup.vim
" 'pos': 'topleft|topright|bottomleft|bottomright|topcenter|bottomcenter',
" }
function! s:create(opt) abort
let id = s:_nextid()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:id (see Anti-pattern of vimrc (Scope of identifier))

autoload/vital/_popup/Experimental/UI/Popup.vim
" }
function! s:create(opt) abort
let id = s:_nextid()
let data = { 'winid': 0 }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))

autoload/vital/_popup/Experimental/UI/Popup.vim
let id = s:_nextid()
let data = { 'winid': 0 }

call s:_set(data, a:opt)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))

autoload/vital/_popup/Experimental/UI/Popup.vim
function! s:hide(id) abort
let data = s:_popups[a:id]
if s:_has_nvim
call nvim_win_close(data['winid'], 1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))

autoload/vital/_popup/Experimental/UI/Popup.vim
let data = s:_popups[a:id]
if s:_has_nvim
call nvim_win_close(data['winid'], 1)
let data['winid'] = 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))

autoload/vital/_popup/Experimental/UI/Popup.vim
call nvim_win_close(data['winid'], 1)
let data['winid'] = 0
else
call popup_hide(data['winid'])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))

autoload/vital/_popup/Experimental/UI/Popup.vim
endfunction

function! s:show(id) abort
let data = s:_popups[a:id]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))

autoload/vital/_popup/Experimental/UI/Popup.vim
function! s:show(id) abort
let data = s:_popups[a:id]
if s:_has_nvim
let data['winid'] = s:_nvim_open_win(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:data (see Anti-pattern of vimrc (Scope of identifier))

@prabirshrestha
Copy link
Owner Author

@hrsh7th I noticed that you also have FloatingWindow vital module that is another option. Looking at your implemention seems like you have implemented more features than mine. One item that seems to be missing is on_create and other events so that as a caller one can easily create custom autocmds such as lsp_float_closed and so on. Also any reason why it depends on markdown instead of asking the callers to do the work. This would be a good popup module independent of markdown.

https://github.com/hrsh7th/vim-vital-vs/blob/master/autoload/vital/__vital__/VS/Vim/Window/FloatingWindow.vim

@prabirshrestha prabirshrestha mentioned this pull request Jan 9, 2021
Merged
@prabirshrestha prabirshrestha changed the title add vital's experimental popup [Do not merge] add vital's experimental popup Jan 9, 2021
@prabirshrestha
Copy link
Owner Author

closing in favor of #1033

@prabirshrestha prabirshrestha deleted the vital-popup branch January 17, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prabirshrestha