Improve completion perf #1038
Merged
Improve completion perf #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabirshrestha
changed the title
|
This removes support for documentation in preview since has impact in perf by computing for all items instead of one that is visible. |
prabirshrestha
added a commit
that referenced
this pull request
Jan 16, 2021
This reverts commit 6038748.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress to improve completion. Need to test with different language servers could be breaking some.
lsp#omni#get_vim_completion_itemsref: optimize lsp#omni#get_vim_completion_items() #835, add lsp#omni#get_vim_completion_items() #834get_vim_completion_itemsand instead compute doc when popup is shown for that particular itemget_vim_completion_itemswhen available for even faster perf