Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll keymapping #1058

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Add scroll keymapping #1058

merged 4 commits into from
Feb 22, 2021

Conversation

hrsh7th
Copy link
Collaborator

@hrsh7th hrsh7th commented Jan 25, 2021

This PR aims to support scrolling floating windows.

plugin/lsp.vim Outdated Show resolved Hide resolved
@hrsh7th
Copy link
Collaborator Author

hrsh7th commented Feb 7, 2021

Should we add sample mapping for README.md?

@prabirshrestha
Copy link
Owner

We should add sample in doc.

rest looks good for merge.

@prabirshrestha
Copy link
Owner

What happens if floating window is not supported?

@hrsh7th
Copy link
Collaborator Author

hrsh7th commented Feb 7, 2021

This implementation does not handle preview windows. so if the floating window did not support, it just ignored.

@hrsh7th
Copy link
Collaborator Author

hrsh7th commented Feb 7, 2021

If we add setwinvar(winid, 'lsp_win', 1), we can handle only vim-lsp's windows.
Should I add lsp_win for output.vim and documentation.vim?

@prabirshrestha
Copy link
Owner

I’m ok adding that var.

@prabirshrestha
Copy link
Owner

@hrsh7th let me know if you had a chance to look at the comments.

@hrsh7th
Copy link
Collaborator Author

hrsh7th commented Feb 16, 2021

Sorry. I was losing a lot of time to fix my buggy completion engine... (it still buggy...)

For the time being, I'm back to finish this PR.

@prabirshrestha
Copy link
Owner

@hrsh7th is this good to merge now or still buggy?

@prabirshrestha prabirshrestha self-requested a review February 22, 2021 11:43
@hrsh7th
Copy link
Collaborator Author

hrsh7th commented Feb 22, 2021

Ah. Sorry for my poor English.
This PR is not buggy. I think it ready to merge.

The buggy plugin was my auto-completion plugin (nvim-compe). I was taken a lot of time due to nvim-compe problems so I couldn't work on this PR.

@hrsh7th hrsh7th merged commit 6a2b97c into prabirshrestha:master Feb 22, 2021
@prabirshrestha
Copy link
Owner

Sounds good. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants