-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scroll keymapping #1058
Add scroll keymapping #1058
Conversation
Should we add sample mapping for README.md? |
We should add sample in doc. rest looks good for merge. |
What happens if floating window is not supported? |
This implementation does not handle preview windows. so if the floating window did not support, it just ignored. |
If we add |
I’m ok adding that var. |
@hrsh7th let me know if you had a chance to look at the comments. |
Sorry. I was losing a lot of time to fix my buggy completion engine... (it still buggy...) For the time being, I'm back to finish this PR. |
@hrsh7th is this good to merge now or still buggy? |
Ah. Sorry for my poor English. The |
Sounds good. Thanks for the PR. |
This PR aims to support scrolling floating windows.