Add float window for hover info #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabirshrestha
requested changes
Mar 20, 2019
autoload/lsp/ui/vim/float.vim
Outdated
| let s:float_height = 0 | ||
|
|
||
| function! s:reset() | ||
| let s:data_buf = [] |
autoload/lsp/ui/vim/hover.vim
Outdated
| @@ -35,7 +35,11 @@ function! s:handle_hover(server, data) abort | |||
| endif | |||
|
|
|||
| if !empty(a:data['response']['result']) && !empty(a:data['response']['result']['contents']) | |||
| call lsp#ui#vim#output#preview(a:data['response']['result']['contents']) | |||
| if g:lsp_hover_win == "preview" || !has("nvim-0.4.0") | |||
There was a problem hiding this comment.
instead of checking version can we check if the function exists?
doc/vim-lsp.txt
Outdated
| @@ -121,6 +122,12 @@ g:lsp_auto_enable *g:lsp_auto_enable* | |||
| let g:lsp_auto_enable = 1 | |||
| let g:lsp_auto_enable = 0 | |||
|
|
|||
| g:lsp_hover_win *g:lsp_hover_win* | |||
There was a problem hiding this comment.
can we change this to g:lsp_hover_ui?
doc/vim-lsp.txt
Outdated
| @@ -121,6 +122,12 @@ g:lsp_auto_enable *g:lsp_auto_enable* | |||
| let g:lsp_auto_enable = 1 | |||
| let g:lsp_auto_enable = 0 | |||
|
|
|||
| g:lsp_hover_win *g:lsp_hover_win* | |||
| Type: String | |||
There was a problem hiding this comment.
Can we use array of string instead.
let g:lsp_hover_ui = ['float', 'preview']This will allow us to have a consistent pattern when we support other ui.
|
Also would be good to have a screenshot or gifs. |
|
@prabirshrestha Thanks your review and I fix all. This is a screenshot: |
prabirshrestha
requested changes
Mar 30, 2019
| return | ||
| for ui in g:lsp_hover_ui | ||
| if ui == "float" | ||
| if exists("*nvim_open_win") |
There was a problem hiding this comment.
can we cache the exists('*nvim_open_win') in script var?
| if ui == "float" | ||
| if exists("*nvim_open_win") | ||
| call lsp#ui#vim#float#float_open(a:data['response']['result']['contents']) | ||
| return |
There was a problem hiding this comment.
Seems like we need to use echo '' so that the message `Retrieving hover' gets removed for both float and preview.
|
Please refer to #395 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add float window for hover info and default float win.