Add <mods> support for opening new window #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supported commands: - :LspDeclaration - :LspDefinition - :LspTypeDefinition - :LspImplementation
|
Merged. Thanks. |
agrinh
pushed a commit
to agrinh/vim-lsp
that referenced
this pull request
Apr 22, 2020
PR prabirshrestha#776 negated the original condition for opening definitions in new splits. I believe that was not the intentional behavior. This simply reverts that condition to avoid opening goto's from unmodified buffers in new splits.
This was referenced Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an another approach of #763.
First, I don't think this is completely better than #763. This is just a suggestion. I don't care which one you choose.
What this PR changes
:LspDeclaration,:LspDefinition,:LspImplementationand:LspTypeDefinitionnow accept<mods>commands.<mods>is combinations of following Ex commands::aboveleft,:belowright,:botright,:browse,:confirm,:hide,:keepalt,:keepjumps,:keepmarks,:keeppatterns,:leftabove,:lockmarks,:noswapfile:rightbelow,:silent,:tab,:topleft,:verbose,:verticalWhen no
<mods>is specified, do not open a new window (same as before).Example of usage:
:leftabove LspDefinitionSplits horizontally and opens a window to the above.:rightbelow vertical LspDefinitionSplits vertically and opens a window to the right.:tab LspDefinitionOpens a window to the new tabpage.Pros
Cons
:horizontalmod command. We cannot specify "just spliit horizontal".:belowrightor:leftabove, or specify other mod that not related to splitting like:silent(hacking way).