Merge dispatch:mocha-core into practicalmeteor:mocha-core

[aldeed]

This PR adds everything from dispatch:mocha-core into this package. If this is merged and all dependent test driver packages are updated to depend on the newer core and use the exported mochaInstance, then all the test driver packages can be installed alongside each other without conflict.

The main differences:

• "mocha" NPM package is actually included now
• On the server, mochaInstance is exported and you have to use this instance if you want to play nicely with other test driver packages.
• Mocha is automatically initialized in client code, too, so test drivers can just call setReporter and run
• Updated to ES2015 and Meteor 1.3+
• Since this is not backwards compatible, I bumped to 1.0.0 package version
• Updated readme to explain various test driver pkgs

[dankelleher]

👍 for this... the current incompatibilities between this and the dispatch package are seriously harming our CI workflow at the moment.

[Ben305]

Can we get this merged? I'm running into the same problem...

[rbabayoff]

Hi all and @aldeed, we've been on vacation, there are some issues with this pr, we need to update our practicalmeteor:mocha package and move some stuff to the core, specifically:

1. Export mocha symbols - https://github.com/practicalmeteor/meteor-mocha/blob/meteor/meteor/src/index.js
2. Update dependencies on mocha source, since mocha will now be added by this package - https://github.com/practicalmeteor/meteor-mocha/blob/meteor/meteor/src/lib/MochaRunner.coffee

We'll deal with it beginning of next week.

[aldeed]

@rbabayoff Why do mocha symbols need to be exported? They're set up on window/global so there's no need to import them.

[jsep]

@aldeed Yes you are right they are indeed globals, but a lot of people that are using ecmascript package like to use `import { describe, ...} from "meteor/practicalmeteor:mocha". And if you are using a code quality tool as jslint, it will be warning about globals and also we close a issue practicalmeteor/meteor-mocha#20

[aldeed]

@jsep ok, I see. Makes sense.

[jsep]

Hello @aldeed @Ben305 @dankelleher

I just release a release candidate version (2.4.5-rc3.1) of the package using practicalmeteor:mocha-core with the changes of @aldeed

To use it just run meteor add practicalmeteor:mocha@2.4.5-rc3.1

Please feel free to test the changes and let us know any problem.

Thanks

[rbabayoff]

@aldeed, @tmeasday and all, as soon as you ok it's working, we'll publish this as release versions.