Skip to content

Commit

Permalink
Remove healthCheckHTTPPortWarning
Browse files Browse the repository at this point in the history
Fixes jaegertracing#2738

Signed-off-by: pradeepnnv <pradeepnnv@gmail.com>
  • Loading branch information
pradeepnnv committed Jan 31, 2021
1 parent 2ff0a3d commit f2f308c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions cmd/flags/admin.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ const (
adminHTTPPort = "admin-http-port"
adminHTTPHostPort = "admin.http.host-port"

healthCheckHTTPPortWarning = "(deprecated, will be removed after 2020-03-15 or in release v1.19.0, whichever is later)"
adminHTTPPortWarning = "(deprecated, will be removed after 2020-06-30 or in release v1.20.0, whichever is later)"
adminHTTPPortWarning = "(deprecated, will be removed after 2020-06-30 or in release v1.20.0, whichever is later)"
)

// AdminServer runs an HTTP server with admin endpoints, such as healthcheck at /, /metrics, etc.
Expand Down Expand Up @@ -74,7 +73,6 @@ func (s *AdminServer) setLogger(logger *zap.Logger) {

// AddFlags registers CLI flags.
func (s *AdminServer) AddFlags(flagSet *flag.FlagSet) {
flagSet.Int(healthCheckHTTPPort, 0, healthCheckHTTPPortWarning+" see --"+adminHTTPHostPort)
flagSet.Int(adminHTTPPort, 0, adminHTTPPortWarning+" see --"+adminHTTPHostPort)
flagSet.String(adminHTTPHostPort, s.adminHostPort, fmt.Sprintf("The host:port (e.g. 127.0.0.1%s or %s) for the admin server, including health check, /metrics, etc.", s.adminHostPort, s.adminHostPort))
}
Expand Down

0 comments on commit f2f308c

Please sign in to comment.