ci: provide npm publish from PR pipeline #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pradel , |
|
@antongolub sounds good, I will review the prs once I have a bit of time, these days are quite busy (in about 1/2 weeks) |
pradel
requested changes
Dec 17, 2024
| workflow_dispatch: | ||
| inputs: | ||
| repo: | ||
| description: 'gh repo, like `scope/name`' |
There was a problem hiding this comment.
Yes, if rely on PR ref, we can obtain both repo and branch attrs
| with: | ||
| name: build-pr-${{ github.run_id }} | ||
| path: | | ||
| esbuild-node-externals/dist |
There was a problem hiding this comment.
can we just publish everything that is in esbuild-node-externals?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pradel ,
This might be useful for proposals testing