Switch to sms fix #176
Merged
Switch to sms fix #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudigiesler
reviewed
Oct 30, 2018
changes/tasks.py
Outdated
| next_sequence_number=sub["next_sequence_number"], | ||
| lang=sub["lang"], | ||
| schedule=sub["schedule"], | ||
| ) |
There was a problem hiding this comment.
Maybe we can rather do a:
# There's no service info for SMS
if "service_info" in short_name:
continue
To firstly better explain it, and secondly avoid nesting things too deeply.
rudigiesler
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEED should not try and create a SMS service info subscription when user changes channel from WA to SMS.