Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EngageActionView to get option and return refresh header #208

Merged
merged 7 commits into from
Mar 22, 2019
Merged

Update EngageActionView to get option and return refresh header #208

merged 7 commits into from
Mar 22, 2019

Conversation

smn
Copy link
Member

@smn smn commented Mar 21, 2019

The Turn API for this has changed slightly. The option is no longer in
the payload but a top level attribute instead.

Also, we can force a refresh of the UI by returning the X-Turn-Integration-Refresh header
set to true.

@smn
Copy link
Member Author

smn commented Mar 21, 2019

@erikh360 & @rudigiesler I've updated the context action view for the changes I've made in Turn.

erikh360
erikh360 approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@erikh360 erikh360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@smn smn merged commit 755f15e into develop Mar 22, 2019
@jerith jerith deleted the feature/fix-turn-action-endpoints branch March 8, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikh360 erikh360 erikh360 approved these changes

@rudigiesler rudigiesler Awaiting requested review from rudigiesler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smn @erikh360