Feature/mcmr 155 hub cleanup #369
Conversation
| @@ -198,87 +198,10 @@ def baby_switch(self, change): | |||
| self.log.info("Starting switch to baby") | |||
|
|
|||
| self.log.info("Retrieving active subscriptions") | |||
| active_subs = sbm_client.get_subscriptions( | |||
| {"identity": change.registrant_id, "active": True} | |||
| )["results"] | |||
There was a problem hiding this comment.
I'm a little bit confused as to why we're removing certain lines, changing the functionality, instead of just deleting the whole task.
There was a problem hiding this comment.
This task is needed by another validate_implement, I have tried removing it and the entire validate fails, so I opted for removing the part that is not needed in the task
eventstore/test_whatsapp_actions.py
Outdated
| "\u201cSMS\u201d (kusebenza izindleko ezijwayelekile)." | ||
| "body": "We see that your MomConnect WhatsApp " | ||
| "messages are not being delivered. If you would " | ||
| "like to receive your messages over SMS, reply ‘SMS’." |
There was a problem hiding this comment.
These are new things, we definitely don't want to be changing these tests, although I think this functionality is currently switched off, we should keep it in case we want to switch it on again. Ensuring that the message gets translated to the user's message is important.
There was a problem hiding this comment.
makes sense, will also revert this change
changes/tasks.py
Outdated
| "%(optout_ussd)s, for more dial %(popi_ussd)s (Free)." | ||
| "Sorry we can't send WhatsApp msgs to this phone. We'll send your " | ||
| "MomConnect msgs on SMS. To stop dial *134*550*1#, for more dial " | ||
| "*134*550*7#" |
There was a problem hiding this comment.
We probably don't want to change this content, or if we do, we would want to do it in a separate PR, not as part of the cleanup. This is what's creating all the changes in the PO files.
There was a problem hiding this comment.
ahh I see, okay will reverse this
…ed PO file changes
In this PR is the Hub CleanUp
What we are keeping, is the following functionality:
registrations.views.ThirdPartyRegistration. Currently this view uses the new things if the EXTERNAL_REGISTRATIONS_V2 config flag is set. We want to remove all the old functionality for when that flag isn’t set, and just use the new functionality, and remove the flag.
registrations.views.JembiAppRegistration. Here too we want to remove the old functionality, and just keep the EXTERNAL_REGISTRATIONS_V2 functionality, and remove the config flag.
registrations.views.WhatsAppContactCheckViewSet
registrations.views.FacilityCheckView and registrations.views.NCFacilityCheckView
registrations.views.NCSubscriptionView, we want to keep all functionality here