Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending SMSes on whatsapp send errors #376

Merged
merged 4 commits into from
Mar 15, 2021

Conversation

rudigiesler
Copy link
Contributor

No description provided.

Copy link
Contributor

@erikh360 erikh360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and I see the tests are failing


MSISDN_FILENAME = "users.csv"
TURN_URL = "https://whatsapp.turn.io/"
TURN_TOKEN = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you wanted to commit this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thanks, was a mistake. Let me remove it and revoke the token

@rudigiesler
Copy link
Contributor Author

@erikh360 Ready for another review

@rudigiesler rudigiesler merged commit a79a154 into develop Mar 15, 2021
@rudigiesler rudigiesler deleted the MOMZA-1691-remove-whatsapp-delivery-error-action branch March 15, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants