Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cov 658 translations #324

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

moh-moola
Copy link
Contributor

@moh-moola moh-moola commented Jul 22, 2020

  • Add a language screen
  • Add PO language files

@moh-moola moh-moola force-pushed the feature/COV-658-translations branch from c9a535f to d26cb4b Compare July 22, 2020 15:43
Copy link
Contributor

@rudigiesler rudigiesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions around the translations, seems like we've got a lot of strings missing. Otherwise looks good

config/go-app-ussd_popi_user_data.afr_ZA.po Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
@moh-moola moh-moola requested a review from rudigiesler July 31, 2020 10:15
Copy link
Contributor

@rudigiesler rudigiesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On some of the spot checks, I noticed that the wrong translations were being used. Please double check every translation carefully against the spreadsheet

config/go-app-ussd_higherhealth_healthcheck.afr_ZA.json Outdated Show resolved Hide resolved
],
"Please use numbers from list. Do you feel very hot or cold? Are you sweating or shivering? When you touch your forehead, does it feel hot?\n\nReply": [
null,
"Voel jy baie warm of koud? Sweet of bewe jy? Wanneer jy aan jou voorkop vat, voel dit warm?\n\nAntwoord"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have translations for the catchall error, so for the catchall error it should be simple enough to concatenate the error translation with the question translation.

We'll just need to be careful around character counts.

config/go-app-ussd_higherhealth_healthcheck.sot_ZA.po Outdated Show resolved Hide resolved
config/go-app-ussd_higherhealth_healthcheck.sot_ZA.po Outdated Show resolved Hide resolved
config/go-app-ussd_higherhealth_healthcheck.sot_ZA.po Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Show resolved Hide resolved
go-app-ussd_higherhealth_healthcheck.js Outdated Show resolved Hide resolved
@moh-moola moh-moola force-pushed the feature/COV-658-translations branch from 37e1a9d to f21f292 Compare August 3, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants