Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EDD and DoB display for change info #643

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

Buhle79
Copy link
Contributor

@Buhle79 Buhle79 commented Aug 15, 2024

No description provided.

], _.method("isValid")), _.method("format", "DD-MM-YYYY")).join(", ") || $("None")
};
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Buhle79 I now remember why we didn't consider a (dob but no edd) option because a contact with dob would have an edd and at the time we weren't clearing the edd field in RP (not sure if we now do). But it's good to have this check.

Copy link
Contributor

@DevChima DevChima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was going to ask that you add one more test with edd, dob1, dob2 and dob3 but I see it's already there as an old test and it still works.

@Buhle79 Buhle79 merged commit 2cc9b9a into develop Aug 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants