Merge pull request #56 from praekeltfoundation/fix-edd-reminders

Add a check to see that edd gets written to flow results
praekeltfoundation · Oct 22, 2024 · 3db709a · 3db709a
2 parents 1481ccf + 81c7750
commit 3db709a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -29,7 +29,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           repository: praekeltfoundation/flow_tester
-          ref: v0.3.0
+          ref: v0.3.5
           path: flow_tester
           ssh-key: ${{ secrets.SSH_PRIVATE_KEY }}
 

diff --git a/Onboarding/QA/tests/edd-reminders_test.exs b/Onboarding/QA/tests/edd-reminders_test.exs
@@ -484,7 +484,7 @@ defmodule EDDRemindersTest do
         text:  ^edd_confirmation_text,
       })
       |> contact_matches(%{"edd" => ^full_edd})
-      # TODO: Add a test for the write_result
+      |> result_matches(%{name: "edd", value: ^full_edd})
     end
 
     test "edd confirmed -> main menu" do

diff --git a/Onboarding/README.md b/Onboarding/README.md
@@ -28,6 +28,10 @@ Pull requests are welcome. For major changes, please open an issue first to disc
 
 Please make sure to update tests as appropriate.
 
+## Tests
+
+Running the tests requires elixir >= 1.17 (for Date.shift)
+
 ## Opening Journey as Markdown
 You can open a Turn Journey as a markdown file by taking the url, removing `/app` and appending `?format=md`. A one click solution is to add the following code as a bookmark