Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CommonMark-style hard line breaks? #139

Closed
notriddle opened this issue Apr 10, 2017 · 7 comments
Closed

Support CommonMark-style hard line breaks? #139

notriddle opened this issue Apr 10, 2017 · 7 comments
Assignees
@RobertDober
Labels
enhancement

Comments

@notriddle
Copy link

In CommonMark, and the current version of GFM, a hard line break can be made without trailing white space, using a backslash escape:

Roses are red\
Violets are blue\
Rhyming is hard\
Let's add support for popular Markdown extensions

Roses are red
Violets are blue
Rhyming is hard
Let's add support for popular Markdown extensions

http://spec.commonmark.org/0.27/#example-291
@RobertDober
Copy link
Collaborator

Good news I like it, and we should have it.

Bad news I am really lacking time right now.

Anyway thank you for reporting this.

@RobertDober RobertDober added this to the 1.3 milestone Apr 10, 2017
RobertDober added a commit that referenced this issue Apr 12, 2017
@RobertDober
implements #139
d91dba2
@RobertDober RobertDober self-assigned this Apr 12, 2017
@RobertDober
Copy link
Collaborator

@pragdave I have checked this with Babelmark and Github and it was easy to implement the exact behavior in #140 . I implemented this only for gfm: true. Do you agree with this feature?

@RobertDober RobertDober modified the milestones: 1.2.1, 1.3 Apr 12, 2017
@notriddle
Copy link
Author

Sure, no problem there!

@RobertDober
Copy link
Collaborator

Actually I was asking @pragdave

@andreaazzini
Copy link

News about this feature?

@RobertDober
Copy link
Collaborator

I will ping Dave

RobertDober added a commit that referenced this issue May 3, 2017
@RobertDober
Merge pull request #140 from pragdave/i139-gfm-brs
0d479a2 
implements #139
@RobertDober
Copy link
Collaborator

Got the green light from Dave and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertDober RobertDober

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RobertDober @notriddle @andreaazzini