Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double URL encoding/escaping #281

Closed
valpackett opened this issue Sep 22, 2019 · 1 comment
Closed

Double URL encoding/escaping #281

valpackett opened this issue Sep 22, 2019 · 1 comment
Assignees
@RobertDober
Labels
bug

Comments

@valpackett
Copy link

Having links with URL-encoded params e.g.

[xx](https://sturdy-backbone.glitch.me/test?url=https%3A%2F%2Funrelenting.technology%2Fnotes%2F2019-09-16-17-55-29)

breaks the links by encoding again:

<p><a href="https://sturdy-backbone.glitch.me/test?url=https%253A%252F%252Funrelenting.technology%252Fnotes%252F2019-09-16-17-55-29">xx</a></p>\n
@RobertDober
Copy link
Collaborator

Ooops I messed up, it is not Earmark's responsibility to URL-encode the links...
Thank you for reporting this

@RobertDober RobertDober self-assigned this Sep 22, 2019
@RobertDober RobertDober added this to the 1.4.1 milestone Sep 22, 2019
RobertDober added a commit that referenced this issue Sep 23, 2019
@RobertDober
Merge pull request #285 from pragdave/i281-double-url-encoding-in-links
09548fd 
Fixes #281;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertDober RobertDober

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobertDober @valpackett